Re: [PATCH 0/5] Extend TPM PPI interface to support revision 1.3

2019-02-08 Thread Stefan Berger
On 2/8/19 5:00 PM, Jarkko Sakkinen wrote: On Fri, Feb 08, 2019 at 04:21:02PM -0500, Stefan Berger wrote: I still think that in 5/5 branching could be better but is not a biggie for me (does not make the implementation as whole any kind of mess) and since it is now peer tested I rather would not m

Re: [PATCH 0/5] Extend TPM PPI interface to support revision 1.3

2019-02-08 Thread Jarkko Sakkinen
On Fri, Feb 08, 2019 at 04:21:02PM -0500, Stefan Berger wrote: > On 1/18/19 10:00 AM, Jarkko Sakkinen wrote: > > On Fri, Jan 11, 2019 at 08:28:00PM +, Safford, David (GE Global > > Research) wrote: > > > You might mention that this is an important feature, as on at least some > > > systems, pp

Re: [PATCH 0/5] Extend TPM PPI interface to support revision 1.3

2019-02-08 Thread Stefan Berger
On 1/18/19 10:00 AM, Jarkko Sakkinen wrote: On Fri, Jan 11, 2019 at 08:28:00PM +, Safford, David (GE Global Research) wrote: You might mention that this is an important feature, as on at least some systems, ppi function 23 is the only way to enable/disable PCR banks. I have tested this pat

Re: [PATCH 0/5] Extend TPM PPI interface to support revision 1.3

2019-01-18 Thread Jarkko Sakkinen
On Fri, Jan 11, 2019 at 08:28:00PM +, Safford, David (GE Global Research) wrote: > You might mention that this is an important feature, as on at least some > systems, ppi function 23 is the only way to enable/disable PCR banks. > > I have tested this patch set on my HP Spectre laptop, and I a

Re: [PATCH 0/5] Extend TPM PPI interface to support revision 1.3

2019-01-14 Thread Stefan Berger
...@vger.kernel.org; linux-kernel@vger.kernel.org; Stefan Berger Subject: EXT: [PATCH 0/5] Extend TPM PPI interface to support revision 1.3 This series of patches extends the TPM subsystem's PPI support to support TPM PPI revision 1.3 where more commands are supported (up to 101) and the

RE: [PATCH 0/5] Extend TPM PPI interface to support revision 1.3

2019-01-11 Thread Safford, David (GE Global Research)
.org; linux-kernel@vger.kernel.org; > Stefan Berger > Subject: EXT: [PATCH 0/5] Extend TPM PPI interface to support revision 1.3 > > This series of patches extends the TPM subsystem's PPI support to support > TPM PPI revision 1.3 where more commands are supported (up to 101) a

[PATCH 0/5] Extend TPM PPI interface to support revision 1.3

2019-01-09 Thread Stefan Berger
This series of patches extends the TPM subsystem's PPI support to support TPM PPI revision 1.3 where more commands are supported (up to 101) and the TPM 2 command code '23' takes an additional parameter. For the command code '23' see this document here on document page 39: https://trustedcomputing