Re: [PATCH 0/5] Fix FIFO-99 abuse

2019-08-02 Thread Qais Yousef
On 08/02/19 16:33, Peter Zijlstra wrote: > > > Also also, RR-SMP is actually broken (and nobody has cared enough to > > > bother fixing it). > > > > If you can give me enough pointers to understand the problem I might be > > able to > > bother with it :-) > > So the push-pull balancer we have (d

Re: [PATCH 0/5] Fix FIFO-99 abuse

2019-08-02 Thread Peter Zijlstra
On Fri, Aug 02, 2019 at 03:08:54PM +0100, Qais Yousef wrote: > On 08/02/19 14:41, Peter Zijlstra wrote: > > On Fri, Aug 02, 2019 at 11:26:12AM +0100, Qais Yousef wrote: > > > > > Yes a somewhat enforced default makes more sense to me. I assume you no > > > longer > > > want to put the kthreads th

Re: [PATCH 0/5] Fix FIFO-99 abuse

2019-08-02 Thread Qais Yousef
On 08/02/19 14:41, Peter Zijlstra wrote: > On Fri, Aug 02, 2019 at 11:26:12AM +0100, Qais Yousef wrote: > > > Yes a somewhat enforced default makes more sense to me. I assume you no > > longer > > want to put the kthreads that just need to be above OTHER in FIFO-1? > > I'm not sure, maybe, there

Re: [PATCH 0/5] Fix FIFO-99 abuse

2019-08-02 Thread Peter Zijlstra
On Fri, Aug 02, 2019 at 11:26:12AM +0100, Qais Yousef wrote: > Yes a somewhat enforced default makes more sense to me. I assume you no longer > want to put the kthreads that just need to be above OTHER in FIFO-1? I'm not sure, maybe, there's not that many of them, but possibly we add another inte

Re: [PATCH 0/5] Fix FIFO-99 abuse

2019-08-02 Thread Qais Yousef
On 08/02/19 11:32, Peter Zijlstra wrote: > On Thu, Aug 01, 2019 at 02:17:07PM +0100, Qais Yousef wrote: > > On 08/01/19 13:13, Peter Zijlstra wrote: > > > I noticed a bunch of kthreads defaulted to FIFO-99, fix them. > > > > > > The generic default is FIFO-50, the admin will have to configure the

Re: [PATCH 0/5] Fix FIFO-99 abuse

2019-08-02 Thread Thomas Gleixner
On Fri, 2 Aug 2019, Peter Zijlstra wrote: > On Thu, Aug 01, 2019 at 02:17:07PM +0100, Qais Yousef wrote: > > On 08/01/19 13:13, Peter Zijlstra wrote: > > > I noticed a bunch of kthreads defaulted to FIFO-99, fix them. > > > > > > The generic default is FIFO-50, the admin will have to configure the

Re: [PATCH 0/5] Fix FIFO-99 abuse

2019-08-02 Thread Peter Zijlstra
On Thu, Aug 01, 2019 at 02:17:07PM +0100, Qais Yousef wrote: > On 08/01/19 13:13, Peter Zijlstra wrote: > > I noticed a bunch of kthreads defaulted to FIFO-99, fix them. > > > > The generic default is FIFO-50, the admin will have to configure the system > > anyway. > > > > For some the purpose is

Re: [PATCH 0/5] Fix FIFO-99 abuse

2019-08-01 Thread Qais Yousef
On 08/01/19 13:13, Peter Zijlstra wrote: > I noticed a bunch of kthreads defaulted to FIFO-99, fix them. > > The generic default is FIFO-50, the admin will have to configure the system > anyway. > > For some the purpose is to be above OTHER and then FIFO-1 really is > sufficient. I was looking

[PATCH 0/5] Fix FIFO-99 abuse

2019-08-01 Thread Peter Zijlstra
I noticed a bunch of kthreads defaulted to FIFO-99, fix them. The generic default is FIFO-50, the admin will have to configure the system anyway. For some the purpose is to be above OTHER and then FIFO-1 really is sufficient.