Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-12 Thread Greg Kroah-Hartman
On Wed, Sep 12, 2012 at 10:39:48PM -0400, Jason Baron wrote: > On Wed, Sep 12, 2012 at 06:13:30PM -0700, Joe Perches wrote: > > On Thu, 2012-09-06 at 13:53 -0400, Jason Baron wrote: > > > On Thu, Sep 06, 2012 at 09:13:59AM -0700, Greg Kroah-Hartman wrote: > > > > Jason, any ACK on these, or any of

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-12 Thread Jason Baron
On Wed, Sep 12, 2012 at 06:13:30PM -0700, Joe Perches wrote: > On Thu, 2012-09-06 at 13:53 -0400, Jason Baron wrote: > > On Thu, Sep 06, 2012 at 09:13:59AM -0700, Greg Kroah-Hartman wrote: > > > Jason, any ACK on these, or any of the other random dynamic debug > > > patches floating around? What a

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-12 Thread Joe Perches
On Thu, 2012-09-06 at 13:53 -0400, Jason Baron wrote: > On Thu, Sep 06, 2012 at 09:13:59AM -0700, Greg Kroah-Hartman wrote: > > Jason, any ACK on these, or any of the other random dynamic debug > > patches floating around? What am I supposed to be applying here? [] > I just posted some follow up c

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-10 Thread Jason Baron
On Fri, Sep 07, 2012 at 06:55:50PM -0700, Joe Perches wrote: > On Fri, 2012-09-07 at 11:35 -0400, Jason Baron wrote: > > If nobody else thinks this patch is better, let's at least add a comment in > > __dev_printk() and __netdev_printk() to fix dynamic debug, if these are > > changed. > > Or mayb

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-07 Thread Joe Perches
On Fri, 2012-09-07 at 11:35 -0400, Jason Baron wrote: > If nobody else thinks this patch is better, let's at least add a comment in > __dev_printk() and __netdev_printk() to fix dynamic debug, if these are > changed. Or maybe make dynamic_emit_prefix a public function and move the __dynamic__prin

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-07 Thread Jason Baron
On Fri, Sep 07, 2012 at 08:12:01AM -0700, Joe Perches wrote: > On Fri, 2012-09-07 at 10:52 -0400, Jason Baron wrote: > > On Thu, Sep 06, 2012 at 11:43:46AM -0700, Joe Perches wrote: > > > On Thu, 2012-09-06 at 13:51 -0400, Jason Baron wrote: > > > > On Sun, Aug 26, 2012 at 04:25:25AM -0700, Joe Per

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-07 Thread Joe Perches
On Fri, 2012-09-07 at 10:52 -0400, Jason Baron wrote: > On Thu, Sep 06, 2012 at 11:43:46AM -0700, Joe Perches wrote: > > On Thu, 2012-09-06 at 13:51 -0400, Jason Baron wrote: > > > On Sun, Aug 26, 2012 at 04:25:25AM -0700, Joe Perches wrote: > > > > The recent commit to fix dynamic_debug was a bit

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-07 Thread Joe Perches
On Thu, 2012-09-06 at 11:43 -0700, Joe Perches wrote: > On Thu, 2012-09-06 at 13:51 -0400, Jason Baron wrote: > > On Sun, Aug 26, 2012 at 04:25:25AM -0700, Joe Perches wrote: > > > The recent commit to fix dynamic_debug was a bit unclean. > > > Neaten the style for dynamic_debug. > > > Reduce the s

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-07 Thread Jason Baron
On Thu, Sep 06, 2012 at 11:43:46AM -0700, Joe Perches wrote: > On Thu, 2012-09-06 at 13:51 -0400, Jason Baron wrote: > > On Sun, Aug 26, 2012 at 04:25:25AM -0700, Joe Perches wrote: > > > The recent commit to fix dynamic_debug was a bit unclean. > > > Neaten the style for dynamic_debug. > > > Reduc

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-06 Thread Joe Perches
On Thu, 2012-09-06 at 13:51 -0400, Jason Baron wrote: > On Sun, Aug 26, 2012 at 04:25:25AM -0700, Joe Perches wrote: > > The recent commit to fix dynamic_debug was a bit unclean. > > Neaten the style for dynamic_debug. > > Reduce the stack use of message logging that uses netdev_printk > > Add util

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-06 Thread Jason Baron
On Thu, Sep 06, 2012 at 09:13:59AM -0700, Greg Kroah-Hartman wrote: > On Thu, Aug 30, 2012 at 09:48:12PM -0600, Jim Cromie wrote: > > On Thu, Aug 30, 2012 at 11:43 AM, Jim Cromie wrote: > > > On Sun, Aug 26, 2012 at 5:25 AM, Joe Perches wrote: > > >> The recent commit to fix dynamic_debug was a b

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-06 Thread Jason Baron
On Sun, Aug 26, 2012 at 04:25:25AM -0700, Joe Perches wrote: > The recent commit to fix dynamic_debug was a bit unclean. > Neaten the style for dynamic_debug. > Reduce the stack use of message logging that uses netdev_printk > Add utility functions dev_printk_emit and dev_vprintk_emit for /dev/kmsg

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-06 Thread Greg Kroah-Hartman
On Thu, Aug 30, 2012 at 09:48:12PM -0600, Jim Cromie wrote: > On Thu, Aug 30, 2012 at 11:43 AM, Jim Cromie wrote: > > On Sun, Aug 26, 2012 at 5:25 AM, Joe Perches wrote: > >> The recent commit to fix dynamic_debug was a bit unclean. > >> Neaten the style for dynamic_debug. > >> Reduce the stack u

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-08-30 Thread Jim Cromie
On Thu, Aug 30, 2012 at 11:43 AM, Jim Cromie wrote: > On Sun, Aug 26, 2012 at 5:25 AM, Joe Perches wrote: >> The recent commit to fix dynamic_debug was a bit unclean. >> Neaten the style for dynamic_debug. >> Reduce the stack use of message logging that uses netdev_printk >> Add utility functions

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-08-30 Thread Joe Perches
On Thu, 2012-08-30 at 11:43 -0600, Jim Cromie wrote: > On Sun, Aug 26, 2012 at 5:25 AM, Joe Perches wrote: > > The recent commit to fix dynamic_debug was a bit unclean. > > Neaten the style for dynamic_debug. > > Reduce the stack use of message logging that uses netdev_printk > > Add utility funct

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-08-30 Thread Jim Cromie
On Sun, Aug 26, 2012 at 5:25 AM, Joe Perches wrote: > The recent commit to fix dynamic_debug was a bit unclean. > Neaten the style for dynamic_debug. > Reduce the stack use of message logging that uses netdev_printk > Add utility functions dev_printk_emit and dev_vprintk_emit for /dev/kmsg. > > Jo

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-08-30 Thread David Miller
From: Joe Perches Date: Sun, 26 Aug 2012 04:25:25 -0700 > The recent commit to fix dynamic_debug was a bit unclean. > Neaten the style for dynamic_debug. > Reduce the stack use of message logging that uses netdev_printk > Add utility functions dev_printk_emit and dev_vprintk_emit for /dev/kmsg.

[PATCH 0/5] dev_ and dynamic_debug cleanups

2012-08-26 Thread Joe Perches
The recent commit to fix dynamic_debug was a bit unclean. Neaten the style for dynamic_debug. Reduce the stack use of message logging that uses netdev_printk Add utility functions dev_printk_emit and dev_vprintk_emit for /dev/kmsg. Joe Perches (5): dev_dbg/dynamic_debug: Update to use printk_emi