Re: [PATCH 0/5] pinctrl_gpio_get_direction & ingenic fixes

2018-07-11 Thread Paul Cercueil
Hi Linus, Le lun. 9 juil. 2018 à 14:09, Linus Walleij a écrit : Hi folks, On Wed, Jun 27, 2018 at 7:18 PM Andy Shevchenko wrote: Even if GPIO and pin muxing has only one set of buffers to indicate input or output (same registers in use) it's a GPIO driver business to get direction fr

Re: [PATCH 0/5] pinctrl_gpio_get_direction & ingenic fixes

2018-07-09 Thread Linus Walleij
On Thu, Jun 28, 2018 at 9:11 PM Paul Cercueil wrote: > Sure, it'd be pretty straightforward to do it from the GPIO driver, but > I'd still like to hear Linus' point of view about this. I'm not sure about it, I guess it would be my second choice. > As for merging pinctrl-ingenic.c and gpio-ingen

Re: [PATCH 0/5] pinctrl_gpio_get_direction & ingenic fixes

2018-07-09 Thread Linus Walleij
Hi folks, On Wed, Jun 27, 2018 at 7:18 PM Andy Shevchenko wrote: > Even if GPIO and pin muxing has only one set of buffers to indicate > input or output (same registers in use) it's a GPIO driver business to > get direction from GPIO part of IP. > > Looking into the existing code I would rather

Re: [PATCH 0/5] pinctrl_gpio_get_direction & ingenic fixes

2018-06-29 Thread Andy Shevchenko
On Thu, Jun 28, 2018 at 10:11 PM, Paul Cercueil wrote: > Le mer. 27 juin 2018 à 19:18, Andy Shevchenko a > écrit : >> On Wed, Jun 27, 2018 at 2:48 PM, Paul Cercueil >> wrote: >> I dunno what Linus would going to say about this, but I would like to >> see a schematics for this piece of IP. > ft

Re: [PATCH 0/5] pinctrl_gpio_get_direction & ingenic fixes

2018-06-28 Thread Paul Cercueil
Hi Andy, Le mer. 27 juin 2018 à 19:18, Andy Shevchenko a écrit : On Wed, Jun 27, 2018 at 2:48 PM, Paul Cercueil wrote: Hi Linus, Here's a set of (rather RFC) patches, to implement pinctrl_gpio_get_direction(). I did that, because my gpio-ingenic driver calls pinctrl_gpio_set_directio

Re: [PATCH 0/5] pinctrl_gpio_get_direction & ingenic fixes

2018-06-27 Thread Andy Shevchenko
On Wed, Jun 27, 2018 at 2:48 PM, Paul Cercueil wrote: > Hi Linus, > > Here's a set of (rather RFC) patches, to implement > pinctrl_gpio_get_direction(). I did that, because my gpio-ingenic driver > calls pinctrl_gpio_set_direction() within its gpio_chip's .set_direction > callback, but there was n

[PATCH 0/5] pinctrl_gpio_get_direction & ingenic fixes

2018-06-27 Thread Paul Cercueil
Hi Linus, Here's a set of (rather RFC) patches, to implement pinctrl_gpio_get_direction(). I did that, because my gpio-ingenic driver calls pinctrl_gpio_set_direction() within its gpio_chip's .set_direction callback, but there was no corresponding function to implement the .get_direction callback.