Re: [PATCH 0/5] soundwire: fix ACK/NAK handling and improve log

2021-01-19 Thread Vinod Koul
On 15-01-21, 13:37, Bard Liao wrote: > The existing code reports a NAK only when ACK=0 > This is not aligned with the SoundWire 1.x specifications. > > Table 32 in the SoundWire 1.2 specification shows that a Device shall > not set NAK=1 if ACK=1. But Table 33 shows the Combined Response > may

[PATCH 0/5] soundwire: fix ACK/NAK handling and improve log

2021-01-14 Thread Bard Liao
The existing code reports a NAK only when ACK=0 This is not aligned with the SoundWire 1.x specifications. Table 32 in the SoundWire 1.2 specification shows that a Device shall not set NAK=1 if ACK=1. But Table 33 shows the Combined Response may very well be NAK=1/ACK=1, e.g. if another Device