Re: [PATCH 0/5] usb-misc: cleanup sisusbvga

2016-01-06 Thread Joe Perches
On Wed, 2016-01-06 at 16:30 +0100, Peter Senna Tschudin wrote: > is it ok to fix horizontal issues caused by vertical changes in the > vertical changes patch? Yes. > Is it reasonable to respin if other issues are > reported for this series? Your choice. I think it'd be better to respin in any ca

Re: [PATCH 0/5] usb-misc: cleanup sisusbvga

2016-01-06 Thread Peter Senna Tschudin
On Tue, Jan 05, 2016 at 10:53:24AM -0800, Joe Perches wrote: > On Tue, 2016-01-05 at 17:54 +0100, Peter Senna Tschudin wrote: > [] > > Patch 1 is the biggest and fix only whitespace, tab and newline issues. I > > used > > > > $ git diff -w --word-diff=porcelain drivers/usb/misc/sisusbvga/sisusb.c

Re: [PATCH 0/5] usb-misc: cleanup sisusbvga

2016-01-05 Thread Joe Perches
On Tue, 2016-01-05 at 17:54 +0100, Peter Senna Tschudin wrote: [] > Patch 1 is the biggest and fix only whitespace, tab and newline issues. I used > > $ git diff -w --word-diff=porcelain drivers/usb/misc/sisusbvga/sisusb.c > > to verify that this patch do not change any visible character. If the

[PATCH 0/5] usb-misc: cleanup sisusbvga

2016-01-05 Thread Peter Senna Tschudin
The file drivers/usb/misc/sisusbvga/sisusb.c had many (192) coding style issues reported by checkpatch. This file also had a problematic error path in the probe function that could result in dereferencing a null pointer. This patch series fix coding style issues and fix the problematic error pat