Re: [PATCH 0/5] x86: another attempt at x86 pagetable unification

2007-12-20 Thread Glauber de Oliveira Costa
On Dec 20, 2007 10:58 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > > Well, testing for bisectability requires compiling each patch as its > > applied, which gets painful for something like this where any change > > will rebuild the world. And

Re: [PATCH 0/5] x86: another attempt at x86 pagetable unification

2007-12-20 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Well, testing for bisectability requires compiling each patch as its > applied, which gets painful for something like this where any change > will rebuild the world. And dealing with patch conflicts caused by > changing early patches in the s

Re: [PATCH 0/5] x86: another attempt at x86 pagetable unification

2007-12-20 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > it's also a lot less frustrating and a lot more enjoyable that way IMO. > If it's 50 small patches, then so be it ... 50 patches only take ~2 > seconds more for me to apply to x86.git (which time is immediately saved > by the vastly improved reviewability and testability of

Re: [PATCH 0/5] x86: another attempt at x86 pagetable unification

2007-12-20 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > But byte-for-byte identity isn't (necessarily) possible when actually > unifying. If the same function exists in different forms on 32- and > 64-bit, then unifying requires I pick one of them (or perhaps a new > superset) to use in the unified

Re: [PATCH 0/5] x86: another attempt at x86 pagetable unification

2007-12-20 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > >>> found a couple of bugs. >>> >>> firstly, 64-bit wasnt so lucky, you broke >>> iounmap()/change_page_attr() >>> :-) >>> >> Crap. Worked for me. I'll look into it. >> > > well, there's an easy solution for

Re: [PATCH 0/5] x86: another attempt at x86 pagetable unification

2007-12-20 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > found a couple of bugs. > > > > firstly, 64-bit wasnt so lucky, you broke > > iounmap()/change_page_attr() > > :-) > > Crap. Worked for me. I'll look into it. well, there's an easy solution for unification patches: the resulting object fi

Re: [PATCH 0/5] x86: another attempt at x86 pagetable unification

2007-12-20 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > >>> Here's another round of the pagetable unification patches. I've >>> done a few dozen rounds of randconfig builds on both 32- and 64-bit, >>> so I hope that will prevent compile problems in your test >>> environment. >>> >>

Re: [PATCH 0/5] x86: another attempt at x86 pagetable unification

2007-12-20 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > >> Here's another round of the pagetable unification patches. I've done >> a few dozen rounds of randconfig builds on both 32- and 64-bit, so I >> hope that will prevent compile problems in your test environment. >> >>

Re: [PATCH 0/5] x86: another attempt at x86 pagetable unification

2007-12-20 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Here's another round of the pagetable unification patches. I've done > a few dozen rounds of randconfig builds on both 32- and 64-bit, so I > hope that will prevent compile problems in your test environment. > > I've also boot-tested 64-bit a

Re: [PATCH 0/5] x86: another attempt at x86 pagetable unification

2007-12-20 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Hi Ingo, > > Here's another round of the pagetable unification patches. I've done > a few dozen rounds of randconfig builds on both 32- and 64-bit, so I > hope that will prevent compile problems in your test environment. > > I've also boot-t

[PATCH 0/5] x86: another attempt at x86 pagetable unification

2007-12-19 Thread Jeremy Fitzhardinge
Hi Ingo, Here's another round of the pagetable unification patches. I've done a few dozen rounds of randconfig builds on both 32- and 64-bit, so I hope that will prevent compile problems in your test environment. I've also boot-tested 64-bit and 32-bit PAE/non-PAE configs (both paravirt and non-