Re: [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-04-01 Thread Wolfram Sang
On Sat, Mar 09, 2013 at 07:16:43PM +0100, Lars-Peter Clausen wrote: > Currently i2c_del_adapter() returns 0 on success and potentially an error code > on failure. Unfortunately this doesn't mix too well with the Linux device > driver > model. An i2c_adapter is usually registered in a drivers

Re: [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-04-01 Thread Wolfram Sang
On Sat, Mar 09, 2013 at 07:16:43PM +0100, Lars-Peter Clausen wrote: Currently i2c_del_adapter() returns 0 on success and potentially an error code on failure. Unfortunately this doesn't mix too well with the Linux device driver model. An i2c_adapter is usually registered in a drivers probe

Re: [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-03-31 Thread Jean Delvare
On Sat, 9 Mar 2013 19:16:43 +0100, Lars-Peter Clausen wrote: > Lars-Peter Clausen (6): > i2c: Remove detach_adapter > i2c: i2c_del_adapter: Don't treat removing a non-registered adapter > as error > i2c: Ignore return value of i2c_del_adapter() > i2c: Make return type of

Re: [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-03-31 Thread Jean Delvare
On Sat, 30 Mar 2013 21:43:29 +0100, Lars-Peter Clausen wrote: > On 03/30/2013 09:13 PM, Jean Delvare wrote: > > I see: > > > > struct device_driver { > > (...) > > int (*probe) (struct device *dev); > > int (*remove) (struct device *dev); > > > > So the driver core does allow remove

Re: [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-03-31 Thread Jean Delvare
On Sat, 30 Mar 2013 21:43:29 +0100, Lars-Peter Clausen wrote: On 03/30/2013 09:13 PM, Jean Delvare wrote: I see: struct device_driver { (...) int (*probe) (struct device *dev); int (*remove) (struct device *dev); So the driver core does allow remove functions to

Re: [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-03-31 Thread Jean Delvare
On Sat, 9 Mar 2013 19:16:43 +0100, Lars-Peter Clausen wrote: Lars-Peter Clausen (6): i2c: Remove detach_adapter i2c: i2c_del_adapter: Don't treat removing a non-registered adapter as error i2c: Ignore return value of i2c_del_adapter() i2c: Make return type of i2c_del_adapter()

Re: [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-03-30 Thread Lars-Peter Clausen
On 03/30/2013 09:13 PM, Jean Delvare wrote: > Hi Lars, > > On Sat, 9 Mar 2013 19:16:43 +0100, Lars-Peter Clausen wrote: >> Currently i2c_del_adapter() returns 0 on success and potentially an error >> code >> on failure. Unfortunately this doesn't mix too well with the Linux device >> driver >>

Re: [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-03-30 Thread Jean Delvare
Hi Lars, On Sat, 9 Mar 2013 19:16:43 +0100, Lars-Peter Clausen wrote: > Currently i2c_del_adapter() returns 0 on success and potentially an error code > on failure. Unfortunately this doesn't mix too well with the Linux device > driver > model. (...) I see: struct device_driver {

Re: [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-03-30 Thread Wolfram Sang
On Sat, Mar 09, 2013 at 07:16:43PM +0100, Lars-Peter Clausen wrote: > Currently i2c_del_adapter() returns 0 on success and potentially an error code > on failure. Unfortunately this doesn't mix too well with the Linux device > driver > model. An i2c_adapter is usually registered in a drivers

Re: [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-03-30 Thread Wolfram Sang
On Sat, Mar 09, 2013 at 07:16:43PM +0100, Lars-Peter Clausen wrote: Currently i2c_del_adapter() returns 0 on success and potentially an error code on failure. Unfortunately this doesn't mix too well with the Linux device driver model. An i2c_adapter is usually registered in a drivers probe

Re: [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-03-30 Thread Jean Delvare
Hi Lars, On Sat, 9 Mar 2013 19:16:43 +0100, Lars-Peter Clausen wrote: Currently i2c_del_adapter() returns 0 on success and potentially an error code on failure. Unfortunately this doesn't mix too well with the Linux device driver model. (...) I see: struct device_driver { (...)

Re: [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-03-30 Thread Lars-Peter Clausen
On 03/30/2013 09:13 PM, Jean Delvare wrote: Hi Lars, On Sat, 9 Mar 2013 19:16:43 +0100, Lars-Peter Clausen wrote: Currently i2c_del_adapter() returns 0 on success and potentially an error code on failure. Unfortunately this doesn't mix too well with the Linux device driver model. (...)

[PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-03-09 Thread Lars-Peter Clausen
Currently i2c_del_adapter() returns 0 on success and potentially an error code on failure. Unfortunately this doesn't mix too well with the Linux device driver model. An i2c_adapter is usually registered in a drivers probe callback and removed in the drivers remove callback. The Linux device

[PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-03-09 Thread Lars-Peter Clausen
Currently i2c_del_adapter() returns 0 on success and potentially an error code on failure. Unfortunately this doesn't mix too well with the Linux device driver model. An i2c_adapter is usually registered in a drivers probe callback and removed in the drivers remove callback. The Linux device