Re: g_NCR5380 PDMA, was Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-02-19 Thread Finn Thain
On Sun, 19 Feb 2017, Ondrej Zary wrote: > > These two patches are enough to make PDMA work with CD-ROM drives on > 53C400(A), with IRQ enabled or not. They even improve transfer rates > with HDDs because of bigger block size. > Nice! This is a great improvement. > But DTC436 breaks with CDU

Re: g_NCR5380 PDMA, was Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-02-19 Thread Ondrej Zary
On Sunday 19 February 2017 00:27:55 Finn Thain wrote: > On Sat, 18 Feb 2017, Ondrej Zary wrote: > > On Friday 17 February 2017 23:38:12 Finn Thain wrote: > > > On Thu, 16 Feb 2017, Ondrej Zary wrote: > > > > On Tuesday 31 January 2017 02:31:45 Finn Thain wrote: > > > > [...] > > > > > > > > > Are y

Re: g_NCR5380 PDMA, was Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-02-18 Thread Finn Thain
On Sat, 18 Feb 2017, Ondrej Zary wrote: > On Friday 17 February 2017 23:38:12 Finn Thain wrote: > > On Thu, 16 Feb 2017, Ondrej Zary wrote: > > > On Tuesday 31 January 2017 02:31:45 Finn Thain wrote: > > > [...] > > > > > > > Are you trying to figure out which commands are going to > > > > disco

Re: g_NCR5380 PDMA, was Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-02-18 Thread Ondrej Zary
On Friday 17 February 2017 23:38:12 Finn Thain wrote: > On Thu, 16 Feb 2017, Ondrej Zary wrote: > > On Tuesday 31 January 2017 02:31:45 Finn Thain wrote: > > [...] > > > > > Are you trying to figure out which commands are going to disconnect > > > during a transfer? This is really a function of the

Re: g_NCR5380 PDMA, was Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-02-17 Thread Finn Thain
On Thu, 16 Feb 2017, Ondrej Zary wrote: > On Tuesday 31 January 2017 02:31:45 Finn Thain wrote: > [...] > > Are you trying to figure out which commands are going to disconnect > > during a transfer? This is really a function of the firmware in the > > target; there are no good heuristics AFAICT

Re: g_NCR5380 PDMA, was Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-02-16 Thread Ondrej Zary
On Tuesday 31 January 2017 02:31:45 Finn Thain wrote: [...] > Are you trying to figure out which commands are going to disconnect during > a transfer? This is really a function of the firmware in the target; there > are no good heuristics AFAICT, so the PDMA algorithm has to be robust. > mac_scsi h

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-31 Thread Martin K. Petersen
> "Finn" == Finn Thain writes: Finn> This series removes some unused code and related comments, Finn> addresses the warnings generated by 'make W=1' and 'make C=1' and Finn> fixes a theoretical bug in the bus reset method in atari_scsi. Finn> There's also a patch to add a missing error check

g_NCR5380 PDMA, was Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-30 Thread Finn Thain
On Mon, 30 Jan 2017, Ondrej Zary wrote: > > Also tested two CD-ROM drives and they didn't work (machine hangs). They > didn't work before and looks like they never worked with PDMA. > > The fundamental problem of PDMA is that it either transfers all required > data or it breaks horribly. Even

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-30 Thread Ondrej Zary
On Sunday 29 January 2017 02:05:02 Finn Thain wrote: > On Sat, 28 Jan 2017, Ondrej Zary wrote: > > On Monday 16 January 2017 00:50:57 Finn Thain wrote: > > > This series removes some unused code and related comments, addresses > > > the warnings generated by 'make W=1' and 'make C=1' and fixes a >

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-29 Thread Finn Thain
On Mon, 30 Jan 2017, Michael Schmitz wrote: > > Michael, Ondrej, can I get you to review/test please? > > No regressions during testing on my Falcon both using default settings, > i.e. can_queue=1 or internal queueing (can_queue=4, cmd_per_lun=2), and > the legacy IDE driver. > > I've seen a

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-29 Thread Michael Schmitz
Hi Finn, Am 16.01.2017 um 12:50 schrieb Finn Thain: > This series removes some unused code and related comments, > addresses the warnings generated by 'make W=1' and 'make C=1' > and fixes a theoretical bug in the bus reset method in atari_scsi. > > There's also a patch to add a missing error ch

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-28 Thread Finn Thain
On Sat, 28 Jan 2017, Ondrej Zary wrote: > On Monday 16 January 2017 00:50:57 Finn Thain wrote: > > This series removes some unused code and related comments, addresses > > the warnings generated by 'make W=1' and 'make C=1' and fixes a > > theoretical bug in the bus reset method in atari_scsi.

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-28 Thread Ondrej Zary
On Monday 16 January 2017 00:50:57 Finn Thain wrote: > This series removes some unused code and related comments, > addresses the warnings generated by 'make W=1' and 'make C=1' > and fixes a theoretical bug in the bus reset method in atari_scsi. > > There's also a patch to add a missing error chec

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-25 Thread Martin K. Petersen
> "Michael" == Michael Schmitz writes: Michael> Martin, Finn, I'll get to that on the weekend - Auckland Michael> Anniversary Day coming up so plenty of time. Great, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-25 Thread Michael Schmitz
Martin, Finn, I'll get to that on the weekend - Auckland Anniversary Day coming up so plenty of time. Cheers, Michael Am 26.01.2017 um 12:25 schrieb Martin K. Petersen: >> "Finn" == Finn Thain writes: > > Finn> Michael, Ondrej, can I get you to review/test please? > > Pretty plea

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-25 Thread Martin K. Petersen
> "Finn" == Finn Thain writes: Finn> Michael, Ondrej, can I get you to review/test please? Pretty please! -- Martin K. Petersen Oracle Linux Engineering

[PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-15 Thread Finn Thain
This series removes some unused code and related comments, addresses the warnings generated by 'make W=1' and 'make C=1' and fixes a theoretical bug in the bus reset method in atari_scsi. There's also a patch to add a missing error check during target selection. The only target I tested was a QUAN