Re: [PATCH 0/6] prohibit pinning pages in ZONE_MOVABLE

2020-12-07 Thread Michal Hocko
On Mon 07-12-20 16:12:50, Joonsoo Kim wrote: > On Fri, Dec 04, 2020 at 12:50:56PM -0500, Pavel Tatashin wrote: > > > > Yes, this indeed could be a problem for some configurations. I will > > > > add your comment to the commit log of one of the patches. > > > > > > It sounds like there is some inher

Re: [PATCH 0/6] prohibit pinning pages in ZONE_MOVABLE

2020-12-06 Thread Joonsoo Kim
On Fri, Dec 04, 2020 at 12:50:56PM -0500, Pavel Tatashin wrote: > > > Yes, this indeed could be a problem for some configurations. I will > > > add your comment to the commit log of one of the patches. > > > > It sounds like there is some inherent tension here, breaking THP's > > when doing pin_use

Re: [PATCH 0/6] prohibit pinning pages in ZONE_MOVABLE

2020-12-04 Thread Pavel Tatashin
> > ZONE_MOVABLE can be configured via kernel parameter, or when memory > > nodes are onlined after hot-add; so this is something that admins > > configure. ZONE_MOVABLE is designed to gurantee memory hot-plug > > functionality, and not availability of THP, however, I did not know > > about the use

Re: [PATCH 0/6] prohibit pinning pages in ZONE_MOVABLE

2020-12-04 Thread David Hildenbrand
On 04.12.20 18:50, Pavel Tatashin wrote: >>> Yes, this indeed could be a problem for some configurations. I will >>> add your comment to the commit log of one of the patches. >> >> It sounds like there is some inherent tension here, breaking THP's >> when doing pin_user_pages() is a really nasty th

Re: [PATCH 0/6] prohibit pinning pages in ZONE_MOVABLE

2020-12-04 Thread Pavel Tatashin
> > Yes, this indeed could be a problem for some configurations. I will > > add your comment to the commit log of one of the patches. > > It sounds like there is some inherent tension here, breaking THP's > when doing pin_user_pages() is a really nasty thing to do. DMA > benefits greatly from THP.

Re: [PATCH 0/6] prohibit pinning pages in ZONE_MOVABLE

2020-12-04 Thread Jason Gunthorpe
On Fri, Dec 04, 2020 at 10:55:30AM -0500, Pavel Tatashin wrote: > On Thu, Dec 3, 2020 at 11:03 PM Joonsoo Kim wrote: > > > > Hello, > > > > On Wed, Dec 02, 2020 at 12:23:24AM -0500, Pavel Tatashin wrote: > > > When page is pinned it cannot be moved and its physical address stays > > > the same unt

Re: [PATCH 0/6] prohibit pinning pages in ZONE_MOVABLE

2020-12-04 Thread Pavel Tatashin
On Thu, Dec 3, 2020 at 11:03 PM Joonsoo Kim wrote: > > Hello, > > On Wed, Dec 02, 2020 at 12:23:24AM -0500, Pavel Tatashin wrote: > > When page is pinned it cannot be moved and its physical address stays > > the same until pages is unpinned. > > > > This is useful functionality to allows userland

Re: [PATCH 0/6] prohibit pinning pages in ZONE_MOVABLE

2020-12-03 Thread Joonsoo Kim
Hello, On Wed, Dec 02, 2020 at 12:23:24AM -0500, Pavel Tatashin wrote: > When page is pinned it cannot be moved and its physical address stays > the same until pages is unpinned. > > This is useful functionality to allows userland to implementation DMA > access. For example, it is used by vfio in

[PATCH 0/6] prohibit pinning pages in ZONE_MOVABLE

2020-12-01 Thread Pavel Tatashin
When page is pinned it cannot be moved and its physical address stays the same until pages is unpinned. This is useful functionality to allows userland to implementation DMA access. For example, it is used by vfio in vfio_pin_pages(). However, this functionality breaks memory hotplug/hotremove as