Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-06-26 Thread Song Liu
Hi Michal, > On Jun 26, 2019, at 1:26 AM, Michal Koutný wrote: > > Hello Song and I apology for late reply. > > I understand the motivation for the headroom attribute is to achieve > side load throttling before the CPU is fully saturated since your > measurements show that something else gets s

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-06-26 Thread Michal Koutný
Hello Song and I apology for late reply. I understand the motivation for the headroom attribute is to achieve side load throttling before the CPU is fully saturated since your measurements show that something else gets saturated earlier than CPU and causes grow of the observed latency. The second

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-05-21 Thread Song Liu
Hi Michal, > On May 21, 2019, at 6:47 AM, Michal Koutný wrote: > > Hello Song. > > On Wed, Apr 10, 2019 at 07:43:35PM +, Song Liu > wrote: >> The load level above is measured as requests-per-second. >> >> When there is no side workload, the system has about 45% busy CPU with >> load le

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-05-21 Thread Michal Koutný
Hello Song. On Wed, Apr 10, 2019 at 07:43:35PM +, Song Liu wrote: > The load level above is measured as requests-per-second. > > When there is no side workload, the system has about 45% busy CPU with > load level of 1.0; and about 75% busy CPU at load level of 1.5. > > The saturation st

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-05-15 Thread Song Liu
Hi Vincent, > On May 15, 2019, at 3:18 AM, Vincent Guittot > wrote: > > Hi Song, > > On Tue, 14 May 2019 at 22:58, Song Liu wrote: >> >> Hi Vincent, >> > > [snip] > >>> >>> Here are some more results with both Viresh's patch and the cpu.headroom >>> set. In these tests, the side job runs

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-05-15 Thread Vincent Guittot
Hi Song, On Tue, 14 May 2019 at 22:58, Song Liu wrote: > > Hi Vincent, > [snip] > > > > Here are some more results with both Viresh's patch and the cpu.headroom > > set. In these tests, the side job runs with SCHED_IDLE, so we get benefit > > of Viresh's patch. > > > > We collected another metr

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-05-14 Thread Song Liu
Hi Vincent, > On May 10, 2019, at 11:22 AM, Song Liu wrote: > > > >> On Apr 30, 2019, at 9:54 AM, Song Liu wrote: >> >> >> >>> On Apr 30, 2019, at 12:20 PM, Vincent Guittot >>> wrote: >>> >>> Hi Song, >>> >>> On Tue, 30 Apr 2019 at 08:11, Song Liu wrote: > On Apr

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-05-10 Thread Song Liu
> On Apr 30, 2019, at 9:54 AM, Song Liu wrote: > > > >> On Apr 30, 2019, at 12:20 PM, Vincent Guittot >> wrote: >> >> Hi Song, >> >> On Tue, 30 Apr 2019 at 08:11, Song Liu wrote: >>> >>> >>> On Apr 29, 2019, at 8:24 AM, Vincent Guittot wrote: Hi Song, >>>

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-30 Thread Song Liu
> On Apr 30, 2019, at 12:20 PM, Vincent Guittot > wrote: > > Hi Song, > > On Tue, 30 Apr 2019 at 08:11, Song Liu wrote: >> >> >> >>> On Apr 29, 2019, at 8:24 AM, Vincent Guittot >>> wrote: >>> >>> Hi Song, >>> >>> On Sun, 28 Apr 2019 at 21:47, Song Liu wrote: Hi Morten an

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-30 Thread Vincent Guittot
Hi Song, On Tue, 30 Apr 2019 at 08:11, Song Liu wrote: > > > > > On Apr 29, 2019, at 8:24 AM, Vincent Guittot > > wrote: > > > > Hi Song, > > > > On Sun, 28 Apr 2019 at 21:47, Song Liu wrote: > >> > >> Hi Morten and Vincent, > >> > >>> On Apr 22, 2019, at 6:22 PM, Song Liu wrote: > >>> > >>>

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-29 Thread Song Liu
> On Apr 29, 2019, at 8:24 AM, Vincent Guittot > wrote: > > Hi Song, > > On Sun, 28 Apr 2019 at 21:47, Song Liu wrote: >> >> Hi Morten and Vincent, >> >>> On Apr 22, 2019, at 6:22 PM, Song Liu wrote: >>> >>> Hi Vincent, >>> On Apr 17, 2019, at 5:56 AM, Vincent Guittot wrote

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-29 Thread Vincent Guittot
Hi Song, On Sun, 28 Apr 2019 at 21:47, Song Liu wrote: > > Hi Morten and Vincent, > > > On Apr 22, 2019, at 6:22 PM, Song Liu wrote: > > > > Hi Vincent, > > > >> On Apr 17, 2019, at 5:56 AM, Vincent Guittot > >> wrote: > >> > >> On Wed, 10 Apr 2019 at 21:43, Song Liu wrote: > >>> > >>> Hi Mor

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-28 Thread Song Liu
Hi Morten and Vincent, > On Apr 22, 2019, at 6:22 PM, Song Liu wrote: > > Hi Vincent, > >> On Apr 17, 2019, at 5:56 AM, Vincent Guittot >> wrote: >> >> On Wed, 10 Apr 2019 at 21:43, Song Liu wrote: >>> >>> Hi Morten, >>> On Apr 10, 2019, at 4:59 AM, Morten Rasmussen wrote: >>>

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-22 Thread Song Liu
Hi Vincent, > On Apr 17, 2019, at 5:56 AM, Vincent Guittot > wrote: > > On Wed, 10 Apr 2019 at 21:43, Song Liu wrote: >> >> Hi Morten, >> >>> On Apr 10, 2019, at 4:59 AM, Morten Rasmussen >>> wrote: >>> > >>> >>> The bit that isn't clear to me, is _why_ adding idle cycles helps your >>>

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-17 Thread Vincent Guittot
On Wed, 10 Apr 2019 at 21:43, Song Liu wrote: > > Hi Morten, > > > On Apr 10, 2019, at 4:59 AM, Morten Rasmussen > > wrote: > > > > > > The bit that isn't clear to me, is _why_ adding idle cycles helps your > > workload. I'm not convinced that adding headroom gives any latency > > improvements

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-15 Thread Song Liu
Hi Peter, > On Apr 8, 2019, at 2:45 PM, Song Liu wrote: > > Servers running latency sensitive workload usually aren't fully loaded for > various reasons including disaster readiness. The machines running our > interactive workloads (referred as main workload) have a lot of spare CPU > cycles

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-10 Thread Song Liu
Hi Morten, > On Apr 10, 2019, at 4:59 AM, Morten Rasmussen > wrote: > > Hi, > > On Mon, Apr 08, 2019 at 02:45:32PM -0700, Song Liu wrote: >> Servers running latency sensitive workload usually aren't fully loaded for >> various reasons including disaster readiness. The machines running our >>

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-10 Thread Morten Rasmussen
Hi, On Mon, Apr 08, 2019 at 02:45:32PM -0700, Song Liu wrote: > Servers running latency sensitive workload usually aren't fully loaded for > various reasons including disaster readiness. The machines running our > interactive workloads (referred as main workload) have a lot of spare CPU > cycle

[PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-08 Thread Song Liu
Servers running latency sensitive workload usually aren't fully loaded for various reasons including disaster readiness. The machines running our interactive workloads (referred as main workload) have a lot of spare CPU cycles that we would like to use for optimistic side jobs like video encodi