Re: [PATCH 0/8] perf/x86: Rework msr probe interface

2019-05-28 Thread Jiri Olsa
On Tue, May 28, 2019 at 12:01:47PM +0200, Peter Zijlstra wrote: > On Mon, May 27, 2019 at 11:51:21PM +0200, Jiri Olsa wrote: > > hi, > > following up on [1], [2] and [3], this patchset adds update > > attribute groups to pmu, factors out the MSR probe code and > > use it in msr,cstate* and rapl PMU

Re: [PATCH 0/8] perf/x86: Rework msr probe interface

2019-05-28 Thread Peter Zijlstra
On Mon, May 27, 2019 at 11:51:21PM +0200, Jiri Olsa wrote: > hi, > following up on [1], [2] and [3], this patchset adds update > attribute groups to pmu, factors out the MSR probe code and > use it in msr,cstate* and rapl PMUs. > > The functionality stays the same with one exception: > the event i

[PATCH 0/8] perf/x86: Rework msr probe interface

2019-05-27 Thread Jiri Olsa
hi, following up on [1], [2] and [3], this patchset adds update attribute groups to pmu, factors out the MSR probe code and use it in msr,cstate* and rapl PMUs. The functionality stays the same with one exception: the event is not exported if the rdmsr return zero on event's msr. And also: ;-) >