Re: [PATCH 0/8] uprobes: RCU-protected hot path optimizations

2024-08-08 Thread Liao, Chang
在 2024/8/8 1:31, Andrii Nakryiko 写道: > On Wed, Aug 7, 2024 at 10:11 AM Oleg Nesterov wrote: >> >> On 08/07, Andrii Nakryiko wrote: >>> >>> Yes, I was waiting for more of Peter's comments, but I guess I'll just >>> send a v2 today. >> >> OK, >> >>> I'll probably include the SRCU+timeout logic fo

Re: [PATCH 0/8] uprobes: RCU-protected hot path optimizations

2024-08-07 Thread Oleg Nesterov
On 08/07, Andrii Nakryiko wrote: > > Are you going to send a patch with > your bool flag proposal? No, I will wait for the next version from Liao. If he agrees with my comments. If not, we will continue the discussion in that thread. Note also another patch from Liao which removes ->siglock fro

Re: [PATCH 0/8] uprobes: RCU-protected hot path optimizations

2024-08-07 Thread Andrii Nakryiko
On Wed, Aug 7, 2024 at 10:11 AM Oleg Nesterov wrote: > > On 08/07, Andrii Nakryiko wrote: > > > > Yes, I was waiting for more of Peter's comments, but I guess I'll just > > send a v2 today. > > OK, > > > I'll probably include the SRCU+timeout logic for > > return_instances, and maybe lockless VMA

Re: [PATCH 0/8] uprobes: RCU-protected hot path optimizations

2024-08-07 Thread Oleg Nesterov
On 08/07, Andrii Nakryiko wrote: > > Yes, I was waiting for more of Peter's comments, but I guess I'll just > send a v2 today. OK, > I'll probably include the SRCU+timeout logic for > return_instances, and maybe lockless VMA parts as well. Well, feel free to do what you think right, but perhaps

Re: [PATCH 0/8] uprobes: RCU-protected hot path optimizations

2024-08-07 Thread Andrii Nakryiko
On Wed, Aug 7, 2024 at 6:30 AM Oleg Nesterov wrote: > > On 07/31, Andrii Nakryiko wrote: > > > > Andrii Nakryiko (6): > > uprobes: revamp uprobe refcounting and lifetime management > > uprobes: protected uprobe lifetime with SRCU > > uprobes: get rid of enum uprobe_filter_ctx in uprobe filte

Re: [PATCH 0/8] uprobes: RCU-protected hot path optimizations

2024-08-07 Thread Oleg Nesterov
On 07/31, Andrii Nakryiko wrote: > > Andrii Nakryiko (6): > uprobes: revamp uprobe refcounting and lifetime management > uprobes: protected uprobe lifetime with SRCU > uprobes: get rid of enum uprobe_filter_ctx in uprobe filter callbacks > uprobes: travers uprobe's consumer list locklessly

[PATCH 0/8] uprobes: RCU-protected hot path optimizations

2024-07-31 Thread Andrii Nakryiko
This patch set is heavily inspired by Peter Zijlstra's uprobe optimization patches ([0]) and continue that work, albeit trying to keep complexity to the minimum, and attepting to reuse existing primitives as much as possible. The goal here is to optimize obvious uprobe triggering hot path, while ke