Re: [PATCH 0/9] [v3] x86, pkeys: two protection keys bug fixes

2018-05-08 Thread Dave Hansen
> 1) > > Minor patch series organization requests: > > - please include the shortlog and diffstat in the cover letter in the > future, as >it makes it easier to see the overall structure and makes it easier to > reply to >certain commits as a group. Will do. > - please capitalize

Re: [PATCH 0/9] [v3] x86, pkeys: two protection keys bug fixes

2018-04-30 Thread Ram Pai
On Mon, Apr 30, 2018 at 08:30:43AM -0700, Dave Hansen wrote: > On 04/28/2018 12:05 AM, Ingo Molnar wrote: > > In the above kernel that was missing the PROT_EXEC fix I was repeatedly > > running > > the 64-bit and 32-bit testcases as non-root and as root as well, until I > > got a > > hang in th

Re: [PATCH 0/9] [v3] x86, pkeys: two protection keys bug fixes

2018-04-30 Thread Dave Hansen
On 04/28/2018 12:05 AM, Ingo Molnar wrote: > In the above kernel that was missing the PROT_EXEC fix I was repeatedly > running > the 64-bit and 32-bit testcases as non-root and as root as well, until I got > a > hang in the middle of a 32-bit test running as root: > > test 7 PASSED (iterati

Re: [PATCH 0/9] [v3] x86, pkeys: two protection keys bug fixes

2018-04-28 Thread Ingo Molnar
* Ingo Molnar wrote: > The hang problem is still there, if I run a script like this: > > while :; do date; echo -n "32-bit: "; ./protection_keys_32 >/dev/null; date; > echo -n "64-bit: "; ./protection_keys_64 >/dev/null; done > > then within a minute one of the testcases hangs reliably. > >

Re: [PATCH 0/9] [v3] x86, pkeys: two protection keys bug fixes

2018-04-28 Thread Ingo Molnar
* Ingo Molnar wrote: > After I got the GDB backtraces I tried to clean up leftover tasks, but the > main > thread would not go away: > > 4006 pts/000:00:00 protection_keys > > neither SIGCONT nor SIGKILL appears to help: Just seconds after I sent this I found out that this was user er

Re: [PATCH 0/9] [v3] x86, pkeys: two protection keys bug fixes

2018-04-28 Thread Ingo Molnar
* Dave Hansen wrote: > Hi x86 maintainers, > > This set is basically unchanged from the last post. There was > some previous discussion about other ways to fix this with the ppc > folks (Ram Pai), but we've concluded that this x86-specific fix is > fine. I think Ram had a different fix for pp

[PATCH 0/9] [v3] x86, pkeys: two protection keys bug fixes

2018-04-27 Thread Dave Hansen
Hi x86 maintainers, This set is basically unchanged from the last post. There was some previous discussion about other ways to fix this with the ppc folks (Ram Pai), but we've concluded that this x86-specific fix is fine. I think Ram had a different fix for ppc. Changes from v2: * Clarified co