Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-05-10 Thread Martin Schwidefsky
On Wed, 2007-05-09 at 09:35 -0700, Andrew Morton wrote: > > So when will be a good time to add the Kconfig patches to git390? > > Go wild. > > > And do you prefer to let them rot^H^H^Hmature in -mm for a while before > > they can go upstream? > > Your call. I'd be inclined to push them early

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-05-10 Thread Martin Schwidefsky
On Wed, 2007-05-09 at 09:35 -0700, Andrew Morton wrote: So when will be a good time to add the Kconfig patches to git390? Go wild. And do you prefer to let them rot^H^H^Hmature in -mm for a while before they can go upstream? Your call. I'd be inclined to push them early personally -

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-05-09 Thread Andrew Morton
On Wed, 09 May 2007 13:21:50 +0200 Martin Schwidefsky <[EMAIL PROTECTED]> wrote: > On Mon, 2007-04-23 at 10:45 -0700, Andrew Morton wrote: > > > Andrew: I plan to add patches 1-5 to the for-andrew branch of the > > > git390 repository if that is fine with you. The only thing that will > > > be

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-05-09 Thread Martin Schwidefsky
On Mon, 2007-04-23 at 10:45 -0700, Andrew Morton wrote: > > Andrew: I plan to add patches 1-5 to the for-andrew branch of the > > git390 repository if that is fine with you. The only thing that will > > be missing in the tree is the patch that disables wireless for s390. > > The code does compile

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-05-09 Thread Martin Schwidefsky
On Mon, 2007-04-23 at 10:45 -0700, Andrew Morton wrote: Andrew: I plan to add patches 1-5 to the for-andrew branch of the git390 repository if that is fine with you. The only thing that will be missing in the tree is the patch that disables wireless for s390. The code does compile but

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-05-09 Thread Andrew Morton
On Wed, 09 May 2007 13:21:50 +0200 Martin Schwidefsky [EMAIL PROTECTED] wrote: On Mon, 2007-04-23 at 10:45 -0700, Andrew Morton wrote: Andrew: I plan to add patches 1-5 to the for-andrew branch of the git390 repository if that is fine with you. The only thing that will be missing in

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-26 Thread Randy Dunlap
On Thu, 26 Apr 2007 01:30:59 -0700 Andrew Morton wrote: > On Thu, 26 Apr 2007 02:32:06 +0200 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > > > On Thursday 26 April 2007, Andrew Morton wrote: > > > It would be neat if someone could create and maintain a new > > > scripts/spot-common-mistakes.  Feed

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-26 Thread Andy Whitcroft
Andrew Morton wrote: > On Wed, 25 Apr 2007 11:21:33 -0700 > Randy Dunlap <[EMAIL PROTECTED]> wrote: > >> On Mon, 23 Apr 2007 10:45:34 -0700 Andrew Morton wrote: >> >>> On Mon, 23 Apr 2007 16:11:23 +0200 >>> Martin Schwidefsky <[EMAIL PROTECTED]> wrote: >>> Greetings, I've added the

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-26 Thread Andrew Morton
On Thu, 26 Apr 2007 02:32:06 +0200 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Thursday 26 April 2007, Andrew Morton wrote: > > It would be neat if someone could create and maintain a new > > scripts/spot-common-mistakes.  Feed it a unified diff and it would complain > > about newly-added code

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-26 Thread Andrew Morton
On Thu, 26 Apr 2007 02:32:06 +0200 Arnd Bergmann [EMAIL PROTECTED] wrote: On Thursday 26 April 2007, Andrew Morton wrote: It would be neat if someone could create and maintain a new scripts/spot-common-mistakes.  Feed it a unified diff and it would complain about newly-added code (and only

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-26 Thread Andy Whitcroft
Andrew Morton wrote: On Wed, 25 Apr 2007 11:21:33 -0700 Randy Dunlap [EMAIL PROTECTED] wrote: On Mon, 23 Apr 2007 10:45:34 -0700 Andrew Morton wrote: On Mon, 23 Apr 2007 16:11:23 +0200 Martin Schwidefsky [EMAIL PROTECTED] wrote: Greetings, I've added the results of the review to the

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-26 Thread Randy Dunlap
On Thu, 26 Apr 2007 01:30:59 -0700 Andrew Morton wrote: On Thu, 26 Apr 2007 02:32:06 +0200 Arnd Bergmann [EMAIL PROTECTED] wrote: On Thursday 26 April 2007, Andrew Morton wrote: It would be neat if someone could create and maintain a new scripts/spot-common-mistakes.  Feed it a unified

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Dave Jones
On Wed, Apr 25, 2007 at 08:02:07PM -0700, Andrew Morton wrote: > On Wed, 25 Apr 2007 19:38:23 -0700 Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > In fact, I should probably munge it together with a similar thing > > > I wrote at http://www.codemonkey.org.uk/projects/findbugs/ > > > (Warning:

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Andrew Morton
On Wed, 25 Apr 2007 19:38:23 -0700 Randy Dunlap <[EMAIL PROTECTED]> wrote: > Dave Jones wrote: > > On Wed, Apr 25, 2007 at 05:24:47PM -0700, Andrew Morton wrote: > > > > > It would be neat if someone could create and maintain a new > > > scripts/spot-common-mistakes. Feed it a unified diff

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Randy Dunlap
Dave Jones wrote: On Wed, Apr 25, 2007 at 05:24:47PM -0700, Andrew Morton wrote: > It would be neat if someone could create and maintain a new > scripts/spot-common-mistakes. Feed it a unified diff and it would complain > about newly-added code (and only newly-added code) which has busted

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Anton Vorontsov
On Thu, Apr 26, 2007 at 02:32:06AM +0200, Arnd Bergmann wrote: > On Thursday 26 April 2007, Andrew Morton wrote: > > It would be neat if someone could create and maintain a new > > scripts/spot-common-mistakes.  Feed it a unified diff and it would complain > > about newly-added code (and only

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Andrew Morton
On Thu, 26 Apr 2007 02:32:06 +0200 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Thursday 26 April 2007, Andrew Morton wrote: > > It would be neat if someone could create and maintain a new > > scripts/spot-common-mistakes.  Feed it a unified diff and it would complain > > about newly-added code

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Dave Jones
On Wed, Apr 25, 2007 at 05:24:47PM -0700, Andrew Morton wrote: > It would be neat if someone could create and maintain a new > scripts/spot-common-mistakes. Feed it a unified diff and it would complain > about newly-added code (and only newly-added code) which has busted > whitespace, adds

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Arnd Bergmann
On Thursday 26 April 2007, Andrew Morton wrote: > It would be neat if someone could create and maintain a new > scripts/spot-common-mistakes.  Feed it a unified diff and it would complain > about newly-added code (and only newly-added code) which has busted > whitespace, adds new semaphores, adds

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Andrew Morton
On Wed, 25 Apr 2007 14:30:11 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > But that only applies to things which I merge. There's heaps of stuff > coming in via the git trees which is obviously inadequately reviewed - look > at all the instances of open-coded kernel_thread() which were merged

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Andrew Morton
On Wed, 25 Apr 2007 11:21:33 -0700 Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Mon, 23 Apr 2007 10:45:34 -0700 Andrew Morton wrote: > > > On Mon, 23 Apr 2007 16:11:23 +0200 > > Martin Schwidefsky <[EMAIL PROTECTED]> wrote: > > > > > Greetings, > > > I've added the results of the review to the

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Randy Dunlap
On Mon, 23 Apr 2007 10:45:34 -0700 Andrew Morton wrote: > On Mon, 23 Apr 2007 16:11:23 +0200 > Martin Schwidefsky <[EMAIL PROTECTED]> wrote: > > > Greetings, > > I've added the results of the review to the Kconfig cleanup patches > > for s390. Patch #2 has been split, one half has all the

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Randy Dunlap
On Mon, 23 Apr 2007 10:45:34 -0700 Andrew Morton wrote: On Mon, 23 Apr 2007 16:11:23 +0200 Martin Schwidefsky [EMAIL PROTECTED] wrote: Greetings, I've added the results of the review to the Kconfig cleanup patches for s390. Patch #2 has been split, one half has all the HAS_IOMEM

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Andrew Morton
On Wed, 25 Apr 2007 11:21:33 -0700 Randy Dunlap [EMAIL PROTECTED] wrote: On Mon, 23 Apr 2007 10:45:34 -0700 Andrew Morton wrote: On Mon, 23 Apr 2007 16:11:23 +0200 Martin Schwidefsky [EMAIL PROTECTED] wrote: Greetings, I've added the results of the review to the Kconfig cleanup

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Andrew Morton
On Wed, 25 Apr 2007 14:30:11 -0700 Andrew Morton [EMAIL PROTECTED] wrote: But that only applies to things which I merge. There's heaps of stuff coming in via the git trees which is obviously inadequately reviewed - look at all the instances of open-coded kernel_thread() which were merged

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Arnd Bergmann
On Thursday 26 April 2007, Andrew Morton wrote: It would be neat if someone could create and maintain a new scripts/spot-common-mistakes.  Feed it a unified diff and it would complain about newly-added code (and only newly-added code) which has busted whitespace, adds new semaphores, adds new

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Dave Jones
On Wed, Apr 25, 2007 at 05:24:47PM -0700, Andrew Morton wrote: It would be neat if someone could create and maintain a new scripts/spot-common-mistakes. Feed it a unified diff and it would complain about newly-added code (and only newly-added code) which has busted whitespace, adds new

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Andrew Morton
On Thu, 26 Apr 2007 02:32:06 +0200 Arnd Bergmann [EMAIL PROTECTED] wrote: On Thursday 26 April 2007, Andrew Morton wrote: It would be neat if someone could create and maintain a new scripts/spot-common-mistakes.  Feed it a unified diff and it would complain about newly-added code (and only

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Anton Vorontsov
On Thu, Apr 26, 2007 at 02:32:06AM +0200, Arnd Bergmann wrote: On Thursday 26 April 2007, Andrew Morton wrote: It would be neat if someone could create and maintain a new scripts/spot-common-mistakes.  Feed it a unified diff and it would complain about newly-added code (and only newly-added

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Randy Dunlap
Dave Jones wrote: On Wed, Apr 25, 2007 at 05:24:47PM -0700, Andrew Morton wrote: It would be neat if someone could create and maintain a new scripts/spot-common-mistakes. Feed it a unified diff and it would complain about newly-added code (and only newly-added code) which has busted

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Andrew Morton
On Wed, 25 Apr 2007 19:38:23 -0700 Randy Dunlap [EMAIL PROTECTED] wrote: Dave Jones wrote: On Wed, Apr 25, 2007 at 05:24:47PM -0700, Andrew Morton wrote: It would be neat if someone could create and maintain a new scripts/spot-common-mistakes. Feed it a unified diff and it would

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-25 Thread Dave Jones
On Wed, Apr 25, 2007 at 08:02:07PM -0700, Andrew Morton wrote: On Wed, 25 Apr 2007 19:38:23 -0700 Randy Dunlap [EMAIL PROTECTED] wrote: In fact, I should probably munge it together with a similar thing I wrote at http://www.codemonkey.org.uk/projects/findbugs/ (Warning: scary

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-24 Thread Martin Schwidefsky
On Mon, 2007-04-23 at 10:45 -0700, Andrew Morton wrote: > > Andrew: I plan to add patches 1-5 to the for-andrew branch of the > > git390 repository if that is fine with you. The only thing that will > > be missing in the tree is the patch that disables wireless for s390. > > The code does compile

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-24 Thread Martin Schwidefsky
On Mon, 2007-04-23 at 10:45 -0700, Andrew Morton wrote: Andrew: I plan to add patches 1-5 to the for-andrew branch of the git390 repository if that is fine with you. The only thing that will be missing in the tree is the patch that disables wireless for s390. The code does compile but

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-23 Thread Andrew Morton
On Mon, 23 Apr 2007 16:11:23 +0200 Martin Schwidefsky <[EMAIL PROTECTED]> wrote: > Greetings, > I've added the results of the review to the Kconfig cleanup patches > for s390. Patch #2 has been split, one half has all the HAS_IOMEM > depends lines the other the remaining !S390 depends lines. > >

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-23 Thread Arnd Bergmann
On Monday 23 April 2007, Martin Schwidefsky wrote: > I've added the results of the review to the Kconfig cleanup patches > for s390. Patch #2 has been split, one half has all the HAS_IOMEM > depends lines the other the remaining !S390 depends lines. > They all look good to me now - To

[PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-23 Thread Martin Schwidefsky
Greetings, I've added the results of the review to the Kconfig cleanup patches for s390. Patch #2 has been split, one half has all the HAS_IOMEM depends lines the other the remaining !S390 depends lines. Andrew: I plan to add patches 1-5 to the for-andrew branch of the git390 repository if that

[PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-23 Thread Martin Schwidefsky
Greetings, I've added the results of the review to the Kconfig cleanup patches for s390. Patch #2 has been split, one half has all the HAS_IOMEM depends lines the other the remaining !S390 depends lines. Andrew: I plan to add patches 1-5 to the for-andrew branch of the git390 repository if that

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-23 Thread Arnd Bergmann
On Monday 23 April 2007, Martin Schwidefsky wrote: I've added the results of the review to the Kconfig cleanup patches for s390. Patch #2 has been split, one half has all the HAS_IOMEM depends lines the other the remaining !S390 depends lines. They all look good to me now - To unsubscribe

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-04-23 Thread Andrew Morton
On Mon, 23 Apr 2007 16:11:23 +0200 Martin Schwidefsky [EMAIL PROTECTED] wrote: Greetings, I've added the results of the review to the Kconfig cleanup patches for s390. Patch #2 has been split, one half has all the HAS_IOMEM depends lines the other the remaining !S390 depends lines. Andrew: