Re: [PATCH 0/9] TRACE_IRQFLAGS wreckage

2020-08-21 Thread Marco Elver
On Fri, 21 Aug 2020 at 08:54, wrote: > > On Thu, Aug 20, 2020 at 07:20:46PM +0200, Marco Elver wrote: > > From 4ec9dd472c978e1eba622fb22bc04e4357f10421 Mon Sep 17 00:00:00 2001 > > From: Marco Elver > > Date: Thu, 20 Aug 2020 19:06:09 +0200 > > Subject: [PATCH] sched: Turn inline into

Re: [PATCH 0/9] TRACE_IRQFLAGS wreckage

2020-08-21 Thread peterz
On Thu, Aug 20, 2020 at 07:20:46PM +0200, Marco Elver wrote: > From 4ec9dd472c978e1eba622fb22bc04e4357f10421 Mon Sep 17 00:00:00 2001 > From: Marco Elver > Date: Thu, 20 Aug 2020 19:06:09 +0200 > Subject: [PATCH] sched: Turn inline into __always_inline due to noinstr use > > is_idle_task() may

Re: [PATCH 0/9] TRACE_IRQFLAGS wreckage

2020-08-21 Thread Marco Elver
On Thu, Aug 20, 2020 at 03:59PM -0400, Steven Rostedt wrote: > On Thu, 20 Aug 2020 19:20:46 +0200 > Marco Elver wrote: > > > On Thu, Aug 20, 2020 at 04:58PM +0200, pet...@infradead.org wrote: > > > On Thu, Aug 20, 2020 at 10:36:43AM -0400, Steven Rostedt wrote: > > > > > > > > I tested this

Re: [PATCH 0/9] TRACE_IRQFLAGS wreckage

2020-08-20 Thread Steven Rostedt
On Thu, 20 Aug 2020 19:20:46 +0200 Marco Elver wrote: > On Thu, Aug 20, 2020 at 04:58PM +0200, pet...@infradead.org wrote: > > On Thu, Aug 20, 2020 at 10:36:43AM -0400, Steven Rostedt wrote: > > > > > > I tested this series on top of tip/master and triggered the below > > > warning when

Re: [PATCH 0/9] TRACE_IRQFLAGS wreckage

2020-08-20 Thread Marco Elver
On Thu, Aug 20, 2020 at 04:58PM +0200, pet...@infradead.org wrote: > On Thu, Aug 20, 2020 at 10:36:43AM -0400, Steven Rostedt wrote: > > > > I tested this series on top of tip/master and triggered the below > > warning when running the irqsoff tracer boot up test (config attached). > > > > --

Re: [PATCH 0/9] TRACE_IRQFLAGS wreckage

2020-08-20 Thread Steven Rostedt
On Thu, 20 Aug 2020 16:58:21 +0200 pet...@infradead.org wrote: > @@ -91,11 +91,11 @@ void __cpuidle default_idle_call(void) > if (current_clr_polling_and_test()) { > local_irq_enable(); > } else { > - rcu_idle_enter(); > stop_critical_timings();

Re: [PATCH 0/9] TRACE_IRQFLAGS wreckage

2020-08-20 Thread peterz
On Thu, Aug 20, 2020 at 10:36:43AM -0400, Steven Rostedt wrote: > > I tested this series on top of tip/master and triggered the below > warning when running the irqsoff tracer boot up test (config attached). > > -- Steve > > Testing tracer irqsoff: > > = >

Re: [PATCH 0/9] TRACE_IRQFLAGS wreckage

2020-08-20 Thread Steven Rostedt
I tested this series on top of tip/master and triggered the below warning when running the irqsoff tracer boot up test (config attached). -- Steve Testing tracer irqsoff: = WARNING: suspicious RCU usage 5.9.0-rc1-test+ #92 Not tainted

[PATCH 0/9] TRACE_IRQFLAGS wreckage

2020-08-20 Thread Peter Zijlstra
TRACE_IRQFLAGS local_irq_*() keeps a software state that mirrors the hardware state, used for lockdep, includes tracepoints. raw_local_irq_*() does not update the software state, no tracing. --- Problem 1: raw_local_irq_save(); // software state on local_irq_save(); //