Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-06-05 Thread Linus Walleij
On Tue, Jun 4, 2013 at 8:15 PM, Kevin Hilman wrote: > [Me] >> I think this will save a *lot* of identical code in all the >> drivers, that will just have to call >> pinctrl_select_pm_sleep(), pinctrl_select_pm_default() >> pinctrl_select_pm_idle() instead of all the complex code. >> >> This is

Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-06-05 Thread Linus Walleij
On Tue, Jun 4, 2013 at 8:15 PM, Kevin Hilman khil...@linaro.org wrote: [Me] I think this will save a *lot* of identical code in all the drivers, that will just have to call pinctrl_select_pm_sleep(), pinctrl_select_pm_default() pinctrl_select_pm_idle() instead of all the complex code. This

Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-06-04 Thread Mark Brown
On Tue, Jun 04, 2013 at 11:15:51AM -0700, Kevin Hilman wrote: > Linus Walleij writes: > > I think this will save a *lot* of identical code in all the > > drivers, that will just have to call > > pinctrl_select_pm_sleep(), pinctrl_select_pm_default() > > pinctrl_select_pm_idle() instead of all

Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-06-04 Thread Kevin Hilman
Hi Linus, Linus Walleij writes: > On Fri, May 31, 2013 at 7:04 PM, Dmitry Torokhov > wrote: > >> As with the original introduction of pinctrl states my question is: "Can >> all of this be handled in the driver/bus core instead of adding a lot >> of boilerplate code to the individual drivers".

Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-06-04 Thread Linus Walleij
On Fri, May 31, 2013 at 7:04 PM, Dmitry Torokhov wrote: > As with the original introduction of pinctrl states my question is: "Can > all of this be handled in the driver/bus core instead of adding a lot > of boilerplate code to the individual drivers". It can. Per the suggestion in 2/11: -

Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-06-04 Thread Linus Walleij
On Fri, May 31, 2013 at 7:04 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: As with the original introduction of pinctrl states my question is: Can all of this be handled in the driver/bus core instead of adding a lot of boilerplate code to the individual drivers. It can. Per the

Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-06-04 Thread Kevin Hilman
Hi Linus, Linus Walleij linus.wall...@linaro.org writes: On Fri, May 31, 2013 at 7:04 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: As with the original introduction of pinctrl states my question is: Can all of this be handled in the driver/bus core instead of adding a lot of

Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-06-04 Thread Mark Brown
On Tue, Jun 04, 2013 at 11:15:51AM -0700, Kevin Hilman wrote: Linus Walleij linus.wall...@linaro.org writes: I think this will save a *lot* of identical code in all the drivers, that will just have to call pinctrl_select_pm_sleep(), pinctrl_select_pm_default() pinctrl_select_pm_idle()

Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-05-31 Thread Kevin Hilman
+ Linus W. (pinctrl maintainer) Dmitry Torokhov writes: > Hi Hebbar, > > On Fri, May 31, 2013 at 03:43:00PM +0530, Hebbar Gururaja wrote: >> By optionally putting the pins into sleep state in the suspend [or in >> runtime_suspend] callback we can accomplish two things. >> - One is to minimize

Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-05-31 Thread Dmitry Torokhov
Hi Hebbar, On Fri, May 31, 2013 at 03:43:00PM +0530, Hebbar Gururaja wrote: > By optionally putting the pins into sleep state in the suspend [or in > runtime_suspend] callback we can accomplish two things. > - One is to minimize current leakage from pins and thus save power, > - second, we can

[PATCH 00/11] drivers: Add Pinctrl PM support

2013-05-31 Thread Hebbar Gururaja
By optionally putting the pins into sleep state in the suspend [or in runtime_suspend] callback we can accomplish two things. - One is to minimize current leakage from pins and thus save power, - second, we can prevent the IP from driving pins output in an uncontrolled manner, which may happen if

[PATCH 00/11] drivers: Add Pinctrl PM support

2013-05-31 Thread Hebbar Gururaja
By optionally putting the pins into sleep state in the suspend [or in runtime_suspend] callback we can accomplish two things. - One is to minimize current leakage from pins and thus save power, - second, we can prevent the IP from driving pins output in an uncontrolled manner, which may happen if

Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-05-31 Thread Dmitry Torokhov
Hi Hebbar, On Fri, May 31, 2013 at 03:43:00PM +0530, Hebbar Gururaja wrote: By optionally putting the pins into sleep state in the suspend [or in runtime_suspend] callback we can accomplish two things. - One is to minimize current leakage from pins and thus save power, - second, we can

Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-05-31 Thread Kevin Hilman
+ Linus W. (pinctrl maintainer) Dmitry Torokhov dmitry.torok...@gmail.com writes: Hi Hebbar, On Fri, May 31, 2013 at 03:43:00PM +0530, Hebbar Gururaja wrote: By optionally putting the pins into sleep state in the suspend [or in runtime_suspend] callback we can accomplish two things. - One