Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-09-03 Thread Will Deacon
On Fri, Aug 31, 2018 at 08:32:34PM +1000, Nicholas Piggin wrote: > On Fri, 31 Aug 2018 12:10:14 +0200 > Peter Zijlstra wrote: > > > On Fri, Aug 31, 2018 at 10:54:18AM +0100, Will Deacon wrote: > > > > > Proposal below (omitted Linus because that seems to be the pattern > > > elsewhere > > > in

Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-31 Thread Nicholas Piggin
On Fri, 31 Aug 2018 12:49:45 +0200 Peter Zijlstra wrote: > On Fri, Aug 31, 2018 at 08:32:34PM +1000, Nicholas Piggin wrote: > > Oh gee, I suppose. powerpc hash is kind of interesting because it's > > crazy, Aneesh knows that code a lot better than I do. radix modulo > > some minor details of exac

Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-31 Thread Peter Zijlstra
On Fri, Aug 31, 2018 at 12:12:48PM +0100, Will Deacon wrote: > On Fri, Aug 31, 2018 at 12:49:45PM +0200, Peter Zijlstra wrote: > > On Fri, Aug 31, 2018 at 08:32:34PM +1000, Nicholas Piggin wrote: > > > Oh gee, I suppose. powerpc hash is kind of interesting because it's > > > crazy, Aneesh knows tha

Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-31 Thread Will Deacon
On Fri, Aug 31, 2018 at 12:49:45PM +0200, Peter Zijlstra wrote: > On Fri, Aug 31, 2018 at 08:32:34PM +1000, Nicholas Piggin wrote: > > Oh gee, I suppose. powerpc hash is kind of interesting because it's > > crazy, Aneesh knows that code a lot better than I do. radix modulo > > some minor details of

Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-31 Thread Peter Zijlstra
On Fri, Aug 31, 2018 at 08:32:34PM +1000, Nicholas Piggin wrote: > Oh gee, I suppose. powerpc hash is kind of interesting because it's > crazy, Aneesh knows that code a lot better than I do. radix modulo > some minor details of exact instructions is fairly like x86 The whole TLB broadcast vs expl

Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-31 Thread Nicholas Piggin
On Fri, 31 Aug 2018 12:10:14 +0200 Peter Zijlstra wrote: > On Fri, Aug 31, 2018 at 10:54:18AM +0100, Will Deacon wrote: > > > Proposal below (omitted Linus because that seems to be the pattern elsewhere > > in the file and he's not going to shout at himself when things break :) > > Anybody I've

Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-31 Thread Peter Zijlstra
On Fri, Aug 31, 2018 at 10:54:18AM +0100, Will Deacon wrote: > Proposal below (omitted Linus because that seems to be the pattern elsewhere > in the file and he's not going to shout at himself when things break :) > Anybody I've missed? > > Will > > --->8 > > diff --git a/MAINTAINERS b/MAINTAIN

Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-31 Thread Will Deacon
On Thu, Aug 30, 2018 at 06:04:12PM -0700, Linus Torvalds wrote: > On Thu, Aug 30, 2018 at 6:01 PM Nicholas Piggin wrote: > > > > Well it would help if powerpc say wanted to start using them without a > > merge cycle lag. Not a huge issue because powerpc already does > > reasonably well here and th

Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-30 Thread Linus Torvalds
On Thu, Aug 30, 2018 at 6:01 PM Nicholas Piggin wrote: > > Well it would help if powerpc say wanted to start using them without a > merge cycle lag. Not a huge issue because powerpc already does > reasonably well here and there's other work that can be done. Sure. If somebody wants to send the ge

Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-30 Thread Nicholas Piggin
On Thu, 30 Aug 2018 09:39:38 -0700 Linus Torvalds wrote: > On Thu, Aug 30, 2018 at 9:15 AM Will Deacon wrote: > > > > It's also had a lot more testing, but has held up nicely so far on arm64. > > I haven't figured out how to merge this yet, but I'll probably end up > > pulling > > the core chan

Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-30 Thread Peter Zijlstra
On Thu, Aug 30, 2018 at 05:15:34PM +0100, Will Deacon wrote: > Peter Zijlstra (1): > asm-generic/tlb: Track freeing of page-table directories in struct > mmu_gather > > Will Deacon (11): > arm64: tlb: Use last-level invalidation in flush_tlb_kernel_range() > arm64: tlb: Add DSB ISHST pri

Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-30 Thread Linus Torvalds
On Thu, Aug 30, 2018 at 9:15 AM Will Deacon wrote: > > It's also had a lot more testing, but has held up nicely so far on arm64. > I haven't figured out how to merge this yet, but I'll probably end up pulling > the core changes out onto a separate branch. This looks fine, and I'm actually ok gett

[PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-30 Thread Will Deacon
Hello again, This is v1 of the RFC I previously posted here: http://lists.infradead.org/pipermail/linux-arm-kernel/2018-August/597821.html The main changes include: * Rewrite the comment in tlbflush.h to explain the various functions and justify the barrier semantics * Fix the "flush