RE: [PATCH 00/13] lib/generic-radix-tree: genradix bug fix and optimisations.

2020-08-26 Thread David Laight
From: 'Marcelo Ricardo Leitner' > Sent: 25 August 2020 16:41 > > On Tue, Aug 25, 2020 at 02:52:34PM +, David Laight wrote: > > The genradix code is used by SCTP for accessing per-stream data. > > This means there are quite a lot of lookups but the code wasn't > > really optimised at all. > >

RE: [PATCH 00/13] lib/generic-radix-tree: genradix bug fix and optimisations.

2020-08-26 Thread David Laight
From: David Laight > Sent: 26 August 2020 08:36 ... > I'm going to try marking the lookup functions with '__attribute__ ((pure))'. > That should help the sctp code that does repeated SCTP_SI(). > In reality I want to mark them __attribute__ ((const)) - including the > inline wrappers, but that isn'

RE: [PATCH 00/13] lib/generic-radix-tree: genradix bug fix and optimisations.

2020-08-26 Thread David Laight
From: Kent Overstreet > Sent: 25 August 2020 17:32 > > On Tue, Aug 25, 2020 at 04:00:35PM +, David Laight wrote: > > From: 'Marcelo Ricardo Leitner' > > > Sent: 25 August 2020 16:41 > > > > > > On Tue, Aug 25, 2020 at 02:52:34PM +, David Laight wrote: > > > > The genradix code is used by S

Re: [PATCH 00/13] lib/generic-radix-tree: genradix bug fix and optimisations.

2020-08-25 Thread Kent Overstreet
On Tue, Aug 25, 2020 at 04:00:35PM +, David Laight wrote: > From: 'Marcelo Ricardo Leitner' > > Sent: 25 August 2020 16:41 > > > > On Tue, Aug 25, 2020 at 02:52:34PM +, David Laight wrote: > > > The genradix code is used by SCTP for accessing per-stream data. > > > This means there are qui

RE: [PATCH 00/13] lib/generic-radix-tree: genradix bug fix and optimisations.

2020-08-25 Thread David Laight
From: 'Marcelo Ricardo Leitner' > Sent: 25 August 2020 16:41 > > On Tue, Aug 25, 2020 at 02:52:34PM +, David Laight wrote: > > The genradix code is used by SCTP for accessing per-stream data. > > This means there are quite a lot of lookups but the code wasn't > > really optimised at all. > >

Re: [PATCH 00/13] lib/generic-radix-tree: genradix bug fix and optimisations.

2020-08-25 Thread 'Marcelo Ricardo Leitner'
On Tue, Aug 25, 2020 at 02:52:34PM +, David Laight wrote: > The genradix code is used by SCTP for accessing per-stream data. > This means there are quite a lot of lookups but the code wasn't > really optimised at all. My test box is down for the moment and will bring it on later today or tomor

[PATCH 00/13] lib/generic-radix-tree: genradix bug fix and optimisations.

2020-08-25 Thread David Laight
The genradix code is used by SCTP for accessing per-stream data. This means there are quite a lot of lookups but the code wasn't really optimised at all. Patch 1 fixes a rather nasty bug that could cause all sorts of oddities including having a loop in a tree. Fortunately the only 2 users of the g