Re: [PATCH 00/13] workqueue: enhance locking and record global worker id for work data

2013-02-05 Thread Tejun Heo
Hello, Lai. On Wed, Feb 06, 2013 at 12:19:26AM +0800, Lai Jiangshan wrote: > > Can't we just make get_work_pool_id() do a fast path if OFFQ than > > requiring the user to distinguish off and on queue cases? > > old code, get_work_pool_id() is only called when offq. > after series applied, offq_wo

Re: [PATCH 00/13] workqueue: enhance locking and record global worker id for work data

2013-02-05 Thread Lai Jiangshan
On Tue, Feb 5, 2013 at 5:04 AM, Tejun Heo wrote: > Hello, Lai. > > Generally, I *really* like where you're headed but like before it's a > bit difficult for me to apply the patches as-is. Please read on. > > On Fri, Feb 01, 2013 at 02:41:23AM +0800, Lai Jiangshan wrote: >> Better Locking: >> main

Re: [PATCH 00/13] workqueue: enhance locking and record global worker id for work data

2013-02-04 Thread Tejun Heo
Hello, Lai. Generally, I *really* like where you're headed but like before it's a bit difficult for me to apply the patches as-is. Please read on. On Fri, Feb 01, 2013 at 02:41:23AM +0800, Lai Jiangshan wrote: > Better Locking: > mainly based on *mb() which is the most dangerous code and bad for

[PATCH 00/13] workqueue: enhance locking and record global worker id for work data

2013-01-31 Thread Lai Jiangshan
Better Locking: - We have a much complex way to find out on which pool a given work is queued on, mainly based on *mb() which is the most dangerous code and bad for readability. This series change the usage of CWQ bit and makes these code simpler. --PATCH 3,4,5 We have get_work_po