Re: [PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing

2007-10-30 Thread David Brownell
On Tuesday 30 October 2007, David Brownell wrote: > > > > was there something that caught your eye other than the ugly udelay() > > you mentioned in the other thread ? > > That one was a feature that might be more generally necessary, > just to meet chip timing specs.  Mostly they're no trouble.

Re: [PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing

2007-10-30 Thread David Brownell
On Tuesday 30 October 2007, Mike Frysinger wrote: > On 10/30/07, David Brownell <[EMAIL PROTECTED]> wrote: > > And also, pay closer attention to when you may be making > > changes that make device drivers work differently over > > your spi_master controller driver than anyone elses ... > > such

Re: [PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing

2007-10-30 Thread Mike Frysinger
On 10/30/07, David Brownell <[EMAIL PROTECTED]> wrote: > And also, pay closer attention to when you may be making > changes that make device drivers work differently over > your spi_master controller driver than anyone elses ... > such platform-specific behaviors are undesirable, and when > they

Re: [PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing

2007-10-30 Thread David Brownell
On Tuesday 30 October 2007, Bryan Wu wrote: > - BF54x supported > - multi-port supported > - bunch of bug fixing OK, I forwarded these with some more checkpatch.pl fixes. But as I commented elsewhere, please work harder to make sure that your patch comments actually match the patches!! And

[PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing

2007-10-30 Thread Bryan Wu
- BF54x supported - multi-port supported - bunch of bug fixing - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

[PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing

2007-10-30 Thread Bryan Wu
- BF54x supported - multi-port supported - bunch of bug fixing - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing

2007-10-30 Thread David Brownell
On Tuesday 30 October 2007, Bryan Wu wrote: - BF54x supported - multi-port supported - bunch of bug fixing OK, I forwarded these with some more checkpatch.pl fixes. But as I commented elsewhere, please work harder to make sure that your patch comments actually match the patches!! And

Re: [PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing

2007-10-30 Thread Mike Frysinger
On 10/30/07, David Brownell [EMAIL PROTECTED] wrote: And also, pay closer attention to when you may be making changes that make device drivers work differently over your spi_master controller driver than anyone elses ... such platform-specific behaviors are undesirable, and when they go

Re: [PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing

2007-10-30 Thread David Brownell
On Tuesday 30 October 2007, Mike Frysinger wrote: On 10/30/07, David Brownell [EMAIL PROTECTED] wrote: And also, pay closer attention to when you may be making changes that make device drivers work differently over your spi_master controller driver than anyone elses ... such

Re: [PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing

2007-10-30 Thread David Brownell
On Tuesday 30 October 2007, David Brownell wrote: was there something that caught your eye other than the ugly udelay() you mentioned in the other thread ? That one was a feature that might be more generally necessary, just to meet chip timing specs.  Mostly they're no trouble. ...