Re: [PATCH 00/18] KVM: Consolidate and optimize MMU notifiers

2021-03-31 Thread Paolo Bonzini
On 31/03/21 11:34, Marc Zyngier wrote: Queued and 1-9 and 18, thanks.  There's a small issue in patch 10 that prevented me from committing 10-15, but they mostly look good. Can you please push the resulting merge somewhere? I'm concerned that it will conflict in interesting way with other

Re: [PATCH 00/18] KVM: Consolidate and optimize MMU notifiers

2021-03-31 Thread Marc Zyngier
On 2021-03-31 08:57, Paolo Bonzini wrote: Queued and 1-9 and 18, thanks. There's a small issue in patch 10 that prevented me from committing 10-15, but they mostly look good. Can you please push the resulting merge somewhere? I'm concerned that it will conflict in interesting way with other

Re: [PATCH 00/18] KVM: Consolidate and optimize MMU notifiers

2021-03-31 Thread Paolo Bonzini
On 26/03/21 03:19, Sean Christopherson wrote: The end goal of this series is to optimize the MMU notifiers to take mmu_lock if and only if the notification is relevant to KVM, i.e. the hva range overlaps a memslot. Large VMs (hundreds of vCPUs) are very sensitive to mmu_lock being taken for

Re: [PATCH 00/18] KVM: Consolidate and optimize MMU notifiers

2021-03-30 Thread Sean Christopherson
On Tue, Mar 30, 2021, Ben Gardon wrote: > On Thu, Mar 25, 2021 at 7:20 PM Sean Christopherson wrote: > > Patch 10 moves x86's memslot walkers into common KVM. I chose x86 purely > > because I could actually test it. All architectures use nearly identical > > code, so I don't think it actually

Re: [PATCH 00/18] KVM: Consolidate and optimize MMU notifiers

2021-03-30 Thread Paolo Bonzini
On 30/03/21 20:32, Ben Gardon wrote: Patches 1-7 are x86 specific prep patches to play nice with moving the hva->gfn memslot lookups into common code. There ended up being waaay more of these than I expected/wanted, but I had a hell of a time getting the flushing logic right when shuffling the

Re: [PATCH 00/18] KVM: Consolidate and optimize MMU notifiers

2021-03-30 Thread Ben Gardon
On Thu, Mar 25, 2021 at 7:20 PM Sean Christopherson wrote: > > The end goal of this series is to optimize the MMU notifiers to take > mmu_lock if and only if the notification is relevant to KVM, i.e. the hva > range overlaps a memslot. Large VMs (hundreds of vCPUs) are very > sensitive to

[PATCH 00/18] KVM: Consolidate and optimize MMU notifiers

2021-03-25 Thread Sean Christopherson
The end goal of this series is to optimize the MMU notifiers to take mmu_lock if and only if the notification is relevant to KVM, i.e. the hva range overlaps a memslot. Large VMs (hundreds of vCPUs) are very sensitive to mmu_lock being taken for write at inopportune times, and such VMs also tend