Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-21 Thread Gu Zheng
On 05/21/2013 05:42 PM, Libo Chen wrote: > On 2013/5/21 17:06, Thomas Petazzoni wrote: >> Dear Gu Zheng, >> >> On Tue, 21 May 2013 16:00:19 +0800, Gu Zheng wrote: >> Or, maybe make the existing module_platform_driver() macro do this? >>> >>> But not all the modules use module_platform_driver(

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-21 Thread Greg KH
On Tue, May 21, 2013 at 10:42:00AM +0800, Libo Chen wrote: > I find a lot of mistakes using struct platform_driver without owner. > So I pick up some of them including usb and net modules Like others said, make the function call a macro that sets the module owner in it, like all of the other major

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-21 Thread Libo Chen
On 2013/5/21 17:06, Thomas Petazzoni wrote: > Dear Gu Zheng, > > On Tue, 21 May 2013 16:00:19 +0800, Gu Zheng wrote: > >>> Or, maybe make the existing module_platform_driver() macro do this? >> >> But not all the modules use module_platform_driver() macro to replace the >> module init/exit. > >

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-21 Thread Thomas Petazzoni
Dear Gu Zheng, On Tue, 21 May 2013 16:00:19 +0800, Gu Zheng wrote: > > Or, maybe make the existing module_platform_driver() macro do this? > > But not all the modules use module_platform_driver() macro to replace the > module init/exit. Then maybe it's a good opportunity to convert those ones

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-21 Thread Gu Zheng
On 05/21/2013 04:26 PM, Libo Chen wrote: > On 2013/5/21 16:00, Gu Zheng wrote: >> On 05/21/2013 02:41 PM, Thomas Petazzoni wrote: >> >>> Dear David Miller, >>> >>> On Mon, 20 May 2013 23:26:19 -0700 (PDT), David Miller wrote: From: Libo Chen Date: Tue, 21 May 2013 10:42:00 +0800 >>

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-21 Thread Libo Chen
On 2013/5/21 16:00, Gu Zheng wrote: > On 05/21/2013 02:41 PM, Thomas Petazzoni wrote: > >> Dear David Miller, >> >> On Mon, 20 May 2013 23:26:19 -0700 (PDT), David Miller wrote: >>> From: Libo Chen >>> Date: Tue, 21 May 2013 10:42:00 +0800 >>> I find a lot of mistakes using struct platform_d

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-21 Thread Gu Zheng
On 05/21/2013 02:41 PM, Thomas Petazzoni wrote: > Dear David Miller, > > On Mon, 20 May 2013 23:26:19 -0700 (PDT), David Miller wrote: >> From: Libo Chen >> Date: Tue, 21 May 2013 10:42:00 +0800 >> >>> I find a lot of mistakes using struct platform_driver without owner. >>> So I pick up some of

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-21 Thread David Miller
From: Thomas Petazzoni Date: Tue, 21 May 2013 08:41:08 +0200 > Dear David Miller, > > On Mon, 20 May 2013 23:26:19 -0700 (PDT), David Miller wrote: >> From: Libo Chen >> Date: Tue, 21 May 2013 10:42:00 +0800 >> >> > I find a lot of mistakes using struct platform_driver without owner. >> > So I

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-20 Thread Thomas Petazzoni
Dear David Miller, On Mon, 20 May 2013 23:26:19 -0700 (PDT), David Miller wrote: > From: Libo Chen > Date: Tue, 21 May 2013 10:42:00 +0800 > > > I find a lot of mistakes using struct platform_driver without owner. > > So I pick up some of them including usb and net modules > > Instead of doing

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-20 Thread David Miller
From: Libo Chen Date: Tue, 21 May 2013 10:42:00 +0800 > I find a lot of mistakes using struct platform_driver without owner. > So I pick up some of them including usb and net modules Instead of doing it this way, which is obviously error prone and easy to forget, make platform_driver_register()

[PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-20 Thread Libo Chen
I find a lot of mistakes using struct platform_driver without owner. So I pick up some of them including usb and net modules Libo Chen (19): drivers/usb/musb: add missing platform_driver owner drivers/usb/host: add missing platform_driver owner drivers/usb/chipidea: add missing platform_driv