Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-20 Thread Josh Poimboeuf
On Tue, Jan 19, 2021 at 01:29:16PM -0800, Nick Desaulniers wrote: > On Mon, Jan 18, 2021 at 9:23 AM Josh Poimboeuf wrote: > > > > On Thu, Jan 14, 2021 at 04:41:28PM -0800, Sami Tolvanen wrote: > > > I can confirm that all the warnings I previously saw are now fixed, > > > but I'm seeing a few new

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-19 Thread Nick Desaulniers
On Mon, Jan 18, 2021 at 9:23 AM Josh Poimboeuf wrote: > > On Thu, Jan 14, 2021 at 04:41:28PM -0800, Sami Tolvanen wrote: > > I can confirm that all the warnings I previously saw are now fixed, > > but I'm seeing a few new ones: > > > > vmlinux.o: warning: objtool:

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-18 Thread Josh Poimboeuf
On Thu, Jan 14, 2021 at 04:41:28PM -0800, Sami Tolvanen wrote: > I can confirm that all the warnings I previously saw are now fixed, > but I'm seeing a few new ones: > > vmlinux.o: warning: objtool: balance_leaf_when_delete()+0x17d4: stack state > mismatch: cfa1=7+192 cfa2=7+176 > vmlinux.o:

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-15 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 9:59 PM Josh Poimboeuf wrote: > > On Fri, Jan 15, 2021 at 09:19:16PM +0100, Sedat Dilek wrote: > > > > vmlinux.o: warning: objtool: balance_leaf_when_delete()+0x17d4: stack > > > > state mismatch: cfa1=7+192 cfa2=7+176 > > > > vmlinux.o: warning: objtool:

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-15 Thread Josh Poimboeuf
On Fri, Jan 15, 2021 at 09:19:16PM +0100, Sedat Dilek wrote: > > > vmlinux.o: warning: objtool: balance_leaf_when_delete()+0x17d4: stack > > > state mismatch: cfa1=7+192 cfa2=7+176 > > > vmlinux.o: warning: objtool: internal_move_pointers_items()+0x9f7: > > > stack state mismatch: cfa1=7+160

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-15 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 8:52 PM Josh Poimboeuf wrote: > > On Thu, Jan 14, 2021 at 04:41:28PM -0800, Sami Tolvanen wrote: > > Hi Josh, > > > > On Thu, Jan 14, 2021 at 11:40 AM Josh Poimboeuf wrote: > > > > > > Add support for proper vmlinux.o validation, which will be needed for > > > Sami's

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-15 Thread Josh Poimboeuf
On Thu, Jan 14, 2021 at 04:41:28PM -0800, Sami Tolvanen wrote: > Hi Josh, > > On Thu, Jan 14, 2021 at 11:40 AM Josh Poimboeuf wrote: > > > > Add support for proper vmlinux.o validation, which will be needed for > > Sami's upcoming x86 LTO set. (And vmlinux validation is the future for > >

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-15 Thread Josh Poimboeuf
On Fri, Jan 15, 2021 at 07:54:29PM +0100, Sedat Dilek wrote: > > > I tried this series on top of clang-cfi and it segfaults here. > > > > > > + info OBJTOOL vmlinux.o > > > + [ != silent_ ] > > > + printf %-7s %s\n OBJTOOL vmlinux.o > > > OBJTOOL vmlinux.o > > > + tools/objtool/objtool orc

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-15 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 4:30 PM Sedat Dilek wrote: > > On Fri, Jan 15, 2021 at 5:51 AM Sedat Dilek wrote: > > > > On Thu, Jan 14, 2021 at 8:40 PM Josh Poimboeuf wrote: > > > > > > Add support for proper vmlinux.o validation, which will be needed for > > > Sami's upcoming x86 LTO set. (And

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-15 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 5:51 AM Sedat Dilek wrote: > > On Thu, Jan 14, 2021 at 8:40 PM Josh Poimboeuf wrote: > > > > Add support for proper vmlinux.o validation, which will be needed for > > Sami's upcoming x86 LTO set. (And vmlinux validation is the future for > > objtool anyway, for other

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-14 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 5:51 AM Sedat Dilek wrote: > > On Thu, Jan 14, 2021 at 8:40 PM Josh Poimboeuf wrote: > > > > Add support for proper vmlinux.o validation, which will be needed for > > Sami's upcoming x86 LTO set. (And vmlinux validation is the future for > > objtool anyway, for other

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-14 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 8:40 PM Josh Poimboeuf wrote: > > Add support for proper vmlinux.o validation, which will be needed for > Sami's upcoming x86 LTO set. (And vmlinux validation is the future for > objtool anyway, for other reasons.) > > This isn't 100% done -- most notably, crypto still

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-14 Thread Nick Desaulniers
On Thu, Jan 14, 2021 at 4:41 PM Sami Tolvanen wrote: > > I can confirm that all the warnings I previously saw are now fixed, > but I'm seeing a few new ones: > > vmlinux.o: warning: objtool: balance_leaf_when_delete()+0x17d4: stack > state mismatch: cfa1=7+192 cfa2=7+176 > vmlinux.o: warning:

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-14 Thread Sami Tolvanen
Hi Josh, On Thu, Jan 14, 2021 at 11:40 AM Josh Poimboeuf wrote: > > Add support for proper vmlinux.o validation, which will be needed for > Sami's upcoming x86 LTO set. (And vmlinux validation is the future for > objtool anyway, for other reasons.) > > This isn't 100% done -- most notably,

[PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-14 Thread Josh Poimboeuf
Add support for proper vmlinux.o validation, which will be needed for Sami's upcoming x86 LTO set. (And vmlinux validation is the future for objtool anyway, for other reasons.) This isn't 100% done -- most notably, crypto still needs to be supported -- but I think this gets us most of the way