Re: [PATCH 00/30] staging: comedi: move 'struct pci_dev *' into comedi_device

2012-07-12 Thread Ian Abbott
On 2012/07/12 10:02 AM, Alan Cox wrote: >> I suppose at a later date we could turn that into a union with a short >> name like u (so comedidev->pcidev would become something like >> comedidev->u.pcidev), which would allow us to stick a 'struct >> usb_interface *' or some other hardware device

Re: [PATCH 00/30] staging: comedi: move 'struct pci_dev *' into comedi_device

2012-07-12 Thread Alan Cox
> I suppose at a later date we could turn that into a union with a short > name like u (so comedidev->pcidev would become something like > comedidev->u.pcidev), which would allow us to stick a 'struct > usb_interface *' or some other hardware device wrapper struct pointer in > the same hole.

Re: [PATCH 00/30] staging: comedi: move 'struct pci_dev *' into comedi_device

2012-07-12 Thread Ian Abbott
On 2012/07/11 10:47 PM, H Hartley Sweeten wrote: > All the comedi pci drivers have a struct pci_dev * in their private > data to hold the pointer to the pci device. Some of the drivers only > have private data because of this pointer. > > Move the variable into the comedi_device struct and remove

Re: [PATCH 00/30] staging: comedi: move 'struct pci_dev *' into comedi_device

2012-07-12 Thread Ian Abbott
On 2012/07/11 10:47 PM, H Hartley Sweeten wrote: All the comedi pci drivers have a struct pci_dev * in their private data to hold the pointer to the pci device. Some of the drivers only have private data because of this pointer. Move the variable into the comedi_device struct and remove the

Re: [PATCH 00/30] staging: comedi: move 'struct pci_dev *' into comedi_device

2012-07-12 Thread Alan Cox
I suppose at a later date we could turn that into a union with a short name like u (so comedidev-pcidev would become something like comedidev-u.pcidev), which would allow us to stick a 'struct usb_interface *' or some other hardware device wrapper struct pointer in the same hole. (Maybe 'h'

Re: [PATCH 00/30] staging: comedi: move 'struct pci_dev *' into comedi_device

2012-07-12 Thread Ian Abbott
On 2012/07/12 10:02 AM, Alan Cox wrote: I suppose at a later date we could turn that into a union with a short name like u (so comedidev-pcidev would become something like comedidev-u.pcidev), which would allow us to stick a 'struct usb_interface *' or some other hardware device wrapper struct

[PATCH 00/30] staging: comedi: move 'struct pci_dev *' into comedi_device

2012-07-11 Thread H Hartley Sweeten
All the comedi pci drivers have a struct pci_dev * in their private data to hold the pointer to the pci device. Some of the drivers only have private data because of this pointer. Move the variable into the comedi_device struct and remove the private data for the drivers that no longer need it.

[PATCH 00/30] staging: comedi: move 'struct pci_dev *' into comedi_device

2012-07-11 Thread H Hartley Sweeten
All the comedi pci drivers have a struct pci_dev * in their private data to hold the pointer to the pci device. Some of the drivers only have private data because of this pointer. Move the variable into the comedi_device struct and remove the private data for the drivers that no longer need it.