Re: [PATCH 00/32] VFS: Introduce filesystem context [ver #8]

2018-06-18 Thread Theodore Y. Ts'o
On Mon, Jun 18, 2018 at 09:30:50PM +0100, David Howells wrote: > > The fscontext code *requires* you to parse the parameters *before* any attempt > to access the superblock is made. Note that this will actually be a problem > for, say, ext4 which passes a text string stored in the superblock

Re: [PATCH 00/32] VFS: Introduce filesystem context [ver #8]

2018-06-18 Thread Theodore Y. Ts'o
On Mon, Jun 18, 2018 at 09:30:50PM +0100, David Howells wrote: > > The fscontext code *requires* you to parse the parameters *before* any attempt > to access the superblock is made. Note that this will actually be a problem > for, say, ext4 which passes a text string stored in the superblock

Re: [PATCH 00/32] VFS: Introduce filesystem context [ver #8]

2018-06-18 Thread Eric W. Biederman
David Howells writes: > Eric W. Biederman wrote: > >> I have read through these patches and I noticed a significant issue. >> >> Today in mount_bdev we do something that looks like: >> >> mount_bdev(...) >> { >> s = sget(..., bdev); >> if (s->s_root) { >> /* Noop */ >>

Re: [PATCH 00/32] VFS: Introduce filesystem context [ver #8]

2018-06-18 Thread Eric W. Biederman
David Howells writes: > Eric W. Biederman wrote: > >> I have read through these patches and I noticed a significant issue. >> >> Today in mount_bdev we do something that looks like: >> >> mount_bdev(...) >> { >> s = sget(..., bdev); >> if (s->s_root) { >> /* Noop */ >>

Re: [PATCH 00/32] VFS: Introduce filesystem context [ver #8]

2018-06-18 Thread David Howells
Eric W. Biederman wrote: > I have read through these patches and I noticed a significant issue. > > Today in mount_bdev we do something that looks like: > > mount_bdev(...) > { > s = sget(..., bdev); > if (s->s_root) { > /* Noop */ > } else { >

Re: [PATCH 00/32] VFS: Introduce filesystem context [ver #8]

2018-06-18 Thread David Howells
Eric W. Biederman wrote: > I have read through these patches and I noticed a significant issue. > > Today in mount_bdev we do something that looks like: > > mount_bdev(...) > { > s = sget(..., bdev); > if (s->s_root) { > /* Noop */ > } else { >

Re: [PATCH 00/32] VFS: Introduce filesystem context [ver #8]

2018-06-14 Thread Eric W. Biederman
David Howells writes: > Here are a set of patches to create a filesystem context prior to setting > up a new mount, populating it with the parsed options/binary data, creating > the superblock and then effecting the mount. This is also used for remount > since much of the parsing stuff is

Re: [PATCH 00/32] VFS: Introduce filesystem context [ver #8]

2018-06-14 Thread Eric W. Biederman
David Howells writes: > Here are a set of patches to create a filesystem context prior to setting > up a new mount, populating it with the parsed options/binary data, creating > the superblock and then effecting the mount. This is also used for remount > since much of the parsing stuff is

[PATCH 00/32] VFS: Introduce filesystem context [ver #8]

2018-05-24 Thread David Howells
Hi Al, Can you take a look at this please, in particular the last 6 patches? Here are a set of patches to create a filesystem context prior to setting up a new mount, populating it with the parsed options/binary data, creating the superblock and then effecting the mount. This is also used for

[PATCH 00/32] VFS: Introduce filesystem context [ver #8]

2018-05-24 Thread David Howells
Hi Al, Can you take a look at this please, in particular the last 6 patches? Here are a set of patches to create a filesystem context prior to setting up a new mount, populating it with the parsed options/binary data, creating the superblock and then effecting the mount. This is also used for