Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Alex Williamson
On Thu, 2015-04-02 at 14:09 +0200, Michael S. Tsirkin wrote: > On Thu, Apr 02, 2015 at 01:23:06AM -0700, Christoph Hellwig wrote: > > The class ids are a hardware defintion, not a kernel API. > > It's part of the API, it's used to decode values in this sysfs file: > /sys/bus/pci/devices//class >

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Jean Delvare
Le Thursday 02 April 2015 à 14:05 +0200, Michael S. Tsirkin a écrit : > On Thu, Apr 02, 2015 at 01:15:30PM +0200, Jean Delvare wrote: > > Le Thursday 02 April 2015 à 12:09 +0200, Michael S. Tsirkin a écrit : > > > On Thu, Apr 02, 2015 at 11:04:16AM +0200, Jean Delvare wrote: > > > > Le Thursday 02

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Michael S. Tsirkin
On Thu, Apr 02, 2015 at 01:23:06AM -0700, Christoph Hellwig wrote: > The class ids are a hardware defintion, not a kernel API. It's part of the API, it's used to decode values in this sysfs file: /sys/bus/pci/devices//class VFIO also made this part of it's kernel API. > Just use the >

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Michael S. Tsirkin
On Thu, Apr 02, 2015 at 01:15:30PM +0200, Jean Delvare wrote: > Le Thursday 02 April 2015 à 12:09 +0200, Michael S. Tsirkin a écrit : > > On Thu, Apr 02, 2015 at 11:04:16AM +0200, Jean Delvare wrote: > > > Le Thursday 02 April 2015 à 01:23 -0700, Christoph Hellwig a écrit : > > > > The class ids

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Jean Delvare
Le Thursday 02 April 2015 à 12:09 +0200, Michael S. Tsirkin a écrit : > On Thu, Apr 02, 2015 at 11:04:16AM +0200, Jean Delvare wrote: > > Le Thursday 02 April 2015 à 01:23 -0700, Christoph Hellwig a écrit : > > > The class ids are a hardware defintion, not a kernel API. Just use the > > >

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Michael S. Tsirkin
On Thu, Apr 02, 2015 at 11:04:16AM +0200, Jean Delvare wrote: > Le Thursday 02 April 2015 à 01:23 -0700, Christoph Hellwig a écrit : > > The class ids are a hardware defintion, not a kernel API. Just use the > > definitions from libpci, or copy over the kernel header if you prefer > > it over the

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Jean Delvare
Le Thursday 02 April 2015 à 01:23 -0700, Christoph Hellwig a écrit : > The class ids are a hardware defintion, not a kernel API. Just use the > definitions from libpci, or copy over the kernel header if you prefer > it over the libpci definutions. I agree with Christoph, such defines would

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Christoph Hellwig
The class ids are a hardware defintion, not a kernel API. Just use the definitions from libpci, or copy over the kernel header if you prefer it over the libpci definutions. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Michael S. Tsirkin
On Thu, Apr 02, 2015 at 09:44:24AM +0200, Jean Delvare wrote: > It could be that a small subset of pci_ids.h could be shared with > user-space. I'm thinking of classes, because that list is short and > stable, so we can give some stability guarantees. But I don't know if > the user-space projects

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Jean Delvare
Hi Michael, Bjorn and all, On Sun, 29 Mar 2015 15:36:55 +0200, Michael S. Tsirkin wrote: > The macros in pci_ids.h are pretty useful for userspace > using the pci sysfs interface, e.g. to decode class > device and vendor sysfs files. > > At the moment userspace is forced to duplicate these

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Jean Delvare
Le Thursday 02 April 2015 à 01:23 -0700, Christoph Hellwig a écrit : The class ids are a hardware defintion, not a kernel API. Just use the definitions from libpci, or copy over the kernel header if you prefer it over the libpci definutions. I agree with Christoph, such defines would better

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Michael S. Tsirkin
On Thu, Apr 02, 2015 at 09:44:24AM +0200, Jean Delvare wrote: It could be that a small subset of pci_ids.h could be shared with user-space. I'm thinking of classes, because that list is short and stable, so we can give some stability guarantees. But I don't know if the user-space projects you

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Christoph Hellwig
The class ids are a hardware defintion, not a kernel API. Just use the definitions from libpci, or copy over the kernel header if you prefer it over the libpci definutions. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Jean Delvare
Hi Michael, Bjorn and all, On Sun, 29 Mar 2015 15:36:55 +0200, Michael S. Tsirkin wrote: The macros in pci_ids.h are pretty useful for userspace using the pci sysfs interface, e.g. to decode class device and vendor sysfs files. At the moment userspace is forced to duplicate these macros

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Michael S. Tsirkin
On Thu, Apr 02, 2015 at 01:23:06AM -0700, Christoph Hellwig wrote: The class ids are a hardware defintion, not a kernel API. It's part of the API, it's used to decode values in this sysfs file: /sys/bus/pci/devices/address/class VFIO also made this part of it's kernel API. Just use the

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Michael S. Tsirkin
On Thu, Apr 02, 2015 at 11:04:16AM +0200, Jean Delvare wrote: Le Thursday 02 April 2015 à 01:23 -0700, Christoph Hellwig a écrit : The class ids are a hardware defintion, not a kernel API. Just use the definitions from libpci, or copy over the kernel header if you prefer it over the libpci

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Michael S. Tsirkin
On Thu, Apr 02, 2015 at 01:15:30PM +0200, Jean Delvare wrote: Le Thursday 02 April 2015 à 12:09 +0200, Michael S. Tsirkin a écrit : On Thu, Apr 02, 2015 at 11:04:16AM +0200, Jean Delvare wrote: Le Thursday 02 April 2015 à 01:23 -0700, Christoph Hellwig a écrit : The class ids are a

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Jean Delvare
Le Thursday 02 April 2015 à 12:09 +0200, Michael S. Tsirkin a écrit : On Thu, Apr 02, 2015 at 11:04:16AM +0200, Jean Delvare wrote: Le Thursday 02 April 2015 à 01:23 -0700, Christoph Hellwig a écrit : The class ids are a hardware defintion, not a kernel API. Just use the definitions from

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Jean Delvare
Le Thursday 02 April 2015 à 14:05 +0200, Michael S. Tsirkin a écrit : On Thu, Apr 02, 2015 at 01:15:30PM +0200, Jean Delvare wrote: Le Thursday 02 April 2015 à 12:09 +0200, Michael S. Tsirkin a écrit : On Thu, Apr 02, 2015 at 11:04:16AM +0200, Jean Delvare wrote: Le Thursday 02 April

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-04-02 Thread Alex Williamson
On Thu, 2015-04-02 at 14:09 +0200, Michael S. Tsirkin wrote: On Thu, Apr 02, 2015 at 01:23:06AM -0700, Christoph Hellwig wrote: The class ids are a hardware defintion, not a kernel API. It's part of the API, it's used to decode values in this sysfs file: /sys/bus/pci/devices/address/class

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-03-30 Thread Michael S. Tsirkin
On Sun, Mar 29, 2015 at 10:59:45AM -0700, Joe Perches wrote: > On Sun, 2015-03-29 at 15:36 +0200, Michael S. Tsirkin wrote: > > The macros in pci_ids.h are pretty useful for userspace > > using the pci sysfs interface, e.g. to decode class > > device and vendor sysfs files. > > > > At the moment

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-03-30 Thread Michael S. Tsirkin
On Sun, Mar 29, 2015 at 10:59:45AM -0700, Joe Perches wrote: On Sun, 2015-03-29 at 15:36 +0200, Michael S. Tsirkin wrote: The macros in pci_ids.h are pretty useful for userspace using the pci sysfs interface, e.g. to decode class device and vendor sysfs files. At the moment userspace

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-03-29 Thread Stefan Richter
On Mar 29 Michael S. Tsirkin wrote: > The macros in pci_ids.h are pretty useful for userspace > using the pci sysfs interface, e.g. to decode class > device and vendor sysfs files. > > At the moment userspace is forced to duplicate these macros (e.g. QEMU does > this, so does gpxe, seabios, etc),

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-03-29 Thread Joe Perches
On Sun, 2015-03-29 at 15:36 +0200, Michael S. Tsirkin wrote: > The macros in pci_ids.h are pretty useful for userspace > using the pci sysfs interface, e.g. to decode class > device and vendor sysfs files. > > At the moment userspace is forced to duplicate these macros (e.g. QEMU does > this, so

[PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-03-29 Thread Michael S. Tsirkin
The macros in pci_ids.h are pretty useful for userspace using the pci sysfs interface, e.g. to decode class device and vendor sysfs files. At the moment userspace is forced to duplicate these macros (e.g. QEMU does this, so does gpxe, seabios, etc), it is better to export them in

[PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-03-29 Thread Michael S. Tsirkin
The macros in pci_ids.h are pretty useful for userspace using the pci sysfs interface, e.g. to decode class device and vendor sysfs files. At the moment userspace is forced to duplicate these macros (e.g. QEMU does this, so does gpxe, seabios, etc), it is better to export them in

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-03-29 Thread Joe Perches
On Sun, 2015-03-29 at 15:36 +0200, Michael S. Tsirkin wrote: The macros in pci_ids.h are pretty useful for userspace using the pci sysfs interface, e.g. to decode class device and vendor sysfs files. At the moment userspace is forced to duplicate these macros (e.g. QEMU does this, so does

Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

2015-03-29 Thread Stefan Richter
On Mar 29 Michael S. Tsirkin wrote: The macros in pci_ids.h are pretty useful for userspace using the pci sysfs interface, e.g. to decode class device and vendor sysfs files. At the moment userspace is forced to duplicate these macros (e.g. QEMU does this, so does gpxe, seabios, etc), it is