Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-21 Thread Geert Uytterhoeven
On Tue, 21 Aug 2007, Satyam Sharma wrote: > On Tue, 21 Aug 2007, Geert Uytterhoeven wrote: > > On Tue, 21 Aug 2007, Satyam Sharma wrote: > > > > > > This is turning rather funny :-) > > > > > > * Why the printk() conversion specifier must be "%llu"? > > > > > > When reusing parts of this code

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-21 Thread Satyam Sharma
On Tue, 21 Aug 2007, Geert Uytterhoeven wrote: > On Tue, 21 Aug 2007, Satyam Sharma wrote: > > > > This is turning rather funny :-) > > > > * Why the printk() conversion specifier must be "%llu"? > > > > When reusing parts of this code (such as this debug message) for another > > 32-bit

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-21 Thread Geert Uytterhoeven
On Tue, 21 Aug 2007, Satyam Sharma wrote: > On Mon, 20 Aug 2007, Geert Uytterhoeven wrote: > > On Sat, 18 Aug 2007, Satyam Sharma wrote: > > > On Sat, 18 Aug 2007, Jan Engelhardt wrote: > > > > On Aug 18 2007 20:07, Satyam Sharma wrote: > > > > >On Fri, 17 Aug 2007, Geert Uytterhoeven wrote: > > >

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-21 Thread Geert Uytterhoeven
On Tue, 21 Aug 2007, Satyam Sharma wrote: On Mon, 20 Aug 2007, Geert Uytterhoeven wrote: On Sat, 18 Aug 2007, Satyam Sharma wrote: On Sat, 18 Aug 2007, Jan Engelhardt wrote: On Aug 18 2007 20:07, Satyam Sharma wrote: On Fri, 17 Aug 2007, Geert Uytterhoeven wrote: On Thu, 16 Aug

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-21 Thread Satyam Sharma
On Tue, 21 Aug 2007, Geert Uytterhoeven wrote: On Tue, 21 Aug 2007, Satyam Sharma wrote: This is turning rather funny :-) * Why the printk() conversion specifier must be %llu? When reusing parts of this code (such as this debug message) for another 32-bit driver (we certainly

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-21 Thread Geert Uytterhoeven
On Tue, 21 Aug 2007, Satyam Sharma wrote: On Tue, 21 Aug 2007, Geert Uytterhoeven wrote: On Tue, 21 Aug 2007, Satyam Sharma wrote: This is turning rather funny :-) * Why the printk() conversion specifier must be %llu? When reusing parts of this code (such as this debug

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-20 Thread Satyam Sharma
Hi Geert, On Mon, 20 Aug 2007, Geert Uytterhoeven wrote: > On Sat, 18 Aug 2007, Satyam Sharma wrote: > > On Sat, 18 Aug 2007, Jan Engelhardt wrote: > > > On Aug 18 2007 20:07, Satyam Sharma wrote: > > > >On Fri, 17 Aug 2007, Geert Uytterhoeven wrote: > > > >> On Thu, 16 Aug 2007, NeilBrown

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-20 Thread Jan Engelhardt
On Aug 20 2007 13:21, Geert Uytterhoeven wrote: >> > >> > dev_dbg(>sbd.core, >> > >> > "%s:%u: bio %u: %u segs %u sectors from %lu\n", >> > >> > - __func__, __LINE__, i, bio_segments(bio), >> > >> > - bio_sectors(bio),

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-20 Thread Geert Uytterhoeven
On Sat, 18 Aug 2007, Satyam Sharma wrote: > On Sat, 18 Aug 2007, Jan Engelhardt wrote: > > On Aug 18 2007 20:07, Satyam Sharma wrote: > > >On Fri, 17 Aug 2007, Geert Uytterhoeven wrote: > > >> On Thu, 16 Aug 2007, NeilBrown wrote: > > >> [...] > > >> >dev_dbg(>sbd.core, > > >> >

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-20 Thread Geert Uytterhoeven
On Sat, 18 Aug 2007, Satyam Sharma wrote: On Sat, 18 Aug 2007, Jan Engelhardt wrote: On Aug 18 2007 20:07, Satyam Sharma wrote: On Fri, 17 Aug 2007, Geert Uytterhoeven wrote: On Thu, 16 Aug 2007, NeilBrown wrote: [...] dev_dbg(dev-sbd.core,

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-20 Thread Jan Engelhardt
On Aug 20 2007 13:21, Geert Uytterhoeven wrote: dev_dbg(dev-sbd.core, %s:%u: bio %u: %u segs %u sectors from %lu\n, - __func__, __LINE__, i, bio_segments(bio), - bio_sectors(bio), sector); -

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-20 Thread Satyam Sharma
Hi Geert, On Mon, 20 Aug 2007, Geert Uytterhoeven wrote: On Sat, 18 Aug 2007, Satyam Sharma wrote: On Sat, 18 Aug 2007, Jan Engelhardt wrote: On Aug 18 2007 20:07, Satyam Sharma wrote: On Fri, 17 Aug 2007, Geert Uytterhoeven wrote: On Thu, 16 Aug 2007, NeilBrown wrote: [...]

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-18 Thread Satyam Sharma
On Sat, 18 Aug 2007, Jan Engelhardt wrote: > On Aug 18 2007 20:07, Satyam Sharma wrote: > >On Fri, 17 Aug 2007, Geert Uytterhoeven wrote: > > > >> On Thu, 16 Aug 2007, NeilBrown wrote: > >> [...] > >> > dev_dbg(>sbd.core, > >> > "%s:%u: bio %u: %u segs

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-18 Thread Jan Engelhardt
On Aug 18 2007 20:07, Satyam Sharma wrote: >On Fri, 17 Aug 2007, Geert Uytterhoeven wrote: > >> On Thu, 16 Aug 2007, NeilBrown wrote: >> [...] >> >dev_dbg(>sbd.core, >> >"%s:%u: bio %u: %u segs %u sectors from %lu\n", >> > - __func__, __LINE__, i,

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-18 Thread Satyam Sharma
On Fri, 17 Aug 2007, Geert Uytterhoeven wrote: > On Thu, 16 Aug 2007, NeilBrown wrote: > [...] > > dev_dbg(>sbd.core, > > "%s:%u: bio %u: %u segs %u sectors from %lu\n", > > - __func__, __LINE__, i, bio_segments(bio), > > -

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-18 Thread Satyam Sharma
On Fri, 17 Aug 2007, Geert Uytterhoeven wrote: On Thu, 16 Aug 2007, NeilBrown wrote: [...] dev_dbg(dev-sbd.core, %s:%u: bio %u: %u segs %u sectors from %lu\n, - __func__, __LINE__, i, bio_segments(bio), -

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-18 Thread Jan Engelhardt
On Aug 18 2007 20:07, Satyam Sharma wrote: On Fri, 17 Aug 2007, Geert Uytterhoeven wrote: On Thu, 16 Aug 2007, NeilBrown wrote: [...] dev_dbg(dev-sbd.core, %s:%u: bio %u: %u segs %u sectors from %lu\n, - __func__, __LINE__, i,

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-18 Thread Satyam Sharma
On Sat, 18 Aug 2007, Jan Engelhardt wrote: On Aug 18 2007 20:07, Satyam Sharma wrote: On Fri, 17 Aug 2007, Geert Uytterhoeven wrote: On Thu, 16 Aug 2007, NeilBrown wrote: [...] dev_dbg(dev-sbd.core, %s:%u: bio %u: %u segs %u sectors from

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-17 Thread Geert Uytterhoeven
On Thu, 16 Aug 2007, NeilBrown wrote: > Every usage of rq_for_each_bio wraps a usage of > bio_for_each_segment, so these can be combined into > rq_for_each_segment. > > We define "struct req_iterator" to hold the 'bio' and 'index' that > are needed for the double iteration. > ---

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-17 Thread Geert Uytterhoeven
On Thu, 16 Aug 2007, NeilBrown wrote: Every usage of rq_for_each_bio wraps a usage of bio_for_each_segment, so these can be combined into rq_for_each_segment. We define struct req_iterator to hold the 'bio' and 'index' that are needed for the double iteration. ---

[PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-16 Thread NeilBrown
Every usage of rq_for_each_bio wraps a usage of bio_for_each_segment, so these can be combined into rq_for_each_segment. We define "struct req_iterator" to hold the 'bio' and 'index' that are needed for the double iteration. Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output

[PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-16 Thread NeilBrown
Every usage of rq_for_each_bio wraps a usage of bio_for_each_segment, so these can be combined into rq_for_each_segment. We define struct req_iterator to hold the 'bio' and 'index' that are needed for the double iteration. Signed-off-by: Neil Brown [EMAIL PROTECTED] ### Diffstat output