Re: [PATCH 006 of 6] md: Add support for reshape of a raid6

2007-02-23 Thread Bill Davidsen
Andrew Morton wrote: On Tue, 20 Feb 2007 17:35:16 +1100 NeilBrown <[EMAIL PROTECTED]> wrote: + for (i = conf->raid_disks ; i-- ; ) { That statement should be dragged out, shot, stomped on then ceremonially incinerated. What's wrong with doing for (i = 0; i < c

Re: [PATCH 006 of 6] md: Add support for reshape of a raid6

2007-02-23 Thread Helge Hafting
Andrew Morton wrote: On Thu, 22 Feb 2007 13:39:56 +1100 Neil Brown <[EMAIL PROTECTED]> wrote: I must right code that Andrew can read. That's write. But more importantly, things that people can immediately see and understand help reduce the possibility of mistakes. Now and in the fut

loops (Re: [PATCH 006 of 6] md: Add support for reshape of a raid6)

2007-02-22 Thread Oleg Verych
> From: Neil Brown > Newsgroups: gmane.linux.raid,gmane.linux.kernel > Subject: Re: [PATCH 006 of 6] md: Add support for reshape of a raid6 > Date: Thu, 22 Feb 2007 13:39:56 +1100 [] > I guess... "Egoless programmer" and all that, "write for others to > read,

Re: [PATCH 006 of 6] md: Add support for reshape of a raid6

2007-02-21 Thread Andrew Morton
On Thu, 22 Feb 2007 13:39:56 +1100 Neil Brown <[EMAIL PROTECTED]> wrote: > I must right code that Andrew can read. That's write. But more importantly, things that people can immediately see and understand help reduce the possibility of mistakes. Now and in the future. If we did all loops like

Re: [PATCH 006 of 6] md: Add support for reshape of a raid6

2007-02-21 Thread Neil Brown
On Wednesday February 21, [EMAIL PROTECTED] wrote: > On Tue, 20 Feb 2007 17:35:16 +1100 > NeilBrown <[EMAIL PROTECTED]> wrote: > > > + for (i = conf->raid_disks ; i-- ; ) { > > That statement should be dragged out, shot, stomped on then ceremonially > incinerated. An experiment in lat

Re: [PATCH 006 of 6] md: Add support for reshape of a raid6

2007-02-21 Thread Rafael J. Wysocki
On Thursday, 22 February 2007 00:58, Andrew Morton wrote: > On Thu, 22 Feb 2007 00:36:22 +0100 > Oleg Verych <[EMAIL PROTECTED]> wrote: > > > > From: Andrew Morton > > > Newsgroups: gmane.linux.raid,gmane.linux.kernel > > > Subject: Re: [PATCH 006 of

Re: [PATCH 006 of 6] md: Add support for reshape of a raid6

2007-02-21 Thread Andrew Morton
On Thu, 22 Feb 2007 00:36:22 +0100 Oleg Verych <[EMAIL PROTECTED]> wrote: > > From: Andrew Morton > > Newsgroups: gmane.linux.raid,gmane.linux.kernel > > Subject: Re: [PATCH 006 of 6] md: Add support for reshape of a raid6 > > Date: Wed, 21 Feb 2007 14:48:06 -0800

Re: [PATCH 006 of 6] md: Add support for reshape of a raid6

2007-02-21 Thread Oleg Verych
> From: Andrew Morton > Newsgroups: gmane.linux.raid,gmane.linux.kernel > Subject: Re: [PATCH 006 of 6] md: Add support for reshape of a raid6 > Date: Wed, 21 Feb 2007 14:48:06 -0800 Hallo. > On Tue, 20 Feb 2007 17:35:16 +1100 > NeilBrown <[EMAIL PROTECTED]> wrote:

Re: [PATCH 006 of 6] md: Add support for reshape of a raid6

2007-02-21 Thread Andrew Morton
On Tue, 20 Feb 2007 17:35:16 +1100 NeilBrown <[EMAIL PROTECTED]> wrote: > + for (i = conf->raid_disks ; i-- ; ) { That statement should be dragged out, shot, stomped on then ceremonially incinerated. What's wrong with doing for (i = 0; i < conf->raid_disks; i++) { in a man

[PATCH 006 of 6] md: Add support for reshape of a raid6

2007-02-19 Thread NeilBrown
i.e. one or more drives can be added and the array will re-stripe while on-line. Most of the interesting work was already done for raid5. This just extends it to raid6. mdadm newer than 2.6 is needed for complete safety, however any version of mdadm which support raid5 reshape will do a good enou