Re: [PATCH 01/03] gpio: rcar: Use lazy disable and mask on suspend

2013-11-14 Thread Laurent Pinchart
Hi Magnus, On Thursday 14 November 2013 17:50:09 Magnus Damm wrote: > On Thu, Nov 14, 2013 at 11:17 AM, Laurent Pinchart wrote: > > On Thursday 14 November 2013 11:03:06 Magnus Damm wrote: > >> On Thu, Nov 14, 2013 at 9:07 AM, Laurent Pinchart wrote: > >> > On Thursday 14 November 2013 07:59:36 Ma

Re: [PATCH 01/03] gpio: rcar: Use lazy disable and mask on suspend

2013-11-14 Thread Magnus Damm
Hi Laurent, On Thu, Nov 14, 2013 at 11:17 AM, Laurent Pinchart wrote: > Hi Magnus, > > On Thursday 14 November 2013 11:03:06 Magnus Damm wrote: >> On Thu, Nov 14, 2013 at 9:07 AM, Laurent Pinchart wrote: >> > On Thursday 14 November 2013 07:59:36 Magnus Damm wrote: >> >> From: Magnus Damm >> >>

Re: [PATCH 01/03] gpio: rcar: Use lazy disable and mask on suspend

2013-11-13 Thread Laurent Pinchart
Hi Magnus, On Thursday 14 November 2013 11:03:06 Magnus Damm wrote: > On Thu, Nov 14, 2013 at 9:07 AM, Laurent Pinchart wrote: > > On Thursday 14 November 2013 07:59:36 Magnus Damm wrote: > >> From: Magnus Damm > >> > >> Set the ->irq_enable() and ->irq_disable() methods to NULL > >> to enable l

Re: [PATCH 01/03] gpio: rcar: Use lazy disable and mask on suspend

2013-11-13 Thread Magnus Damm
Hi Laurent, Thanks for checking the patches. On Thu, Nov 14, 2013 at 9:07 AM, Laurent Pinchart wrote: > Hi Magnus, > > Thank you for the patch. > > On Thursday 14 November 2013 07:59:36 Magnus Damm wrote: >> From: Magnus Damm >> >> Set the ->irq_enable() and ->irq_disable() methods to NULL >> t

Re: [PATCH 01/03] gpio: rcar: Use lazy disable and mask on suspend

2013-11-13 Thread Laurent Pinchart
Hi Magnus, Thank you for the patch. On Thursday 14 November 2013 07:59:36 Magnus Damm wrote: > From: Magnus Damm > > Set the ->irq_enable() and ->irq_disable() methods to NULL > to enable lazy disable of interrupts. Is that just for optimization purpose, or is there another reason ? > Also ex

[PATCH 01/03] gpio: rcar: Use lazy disable and mask on suspend

2013-11-13 Thread Magnus Damm
From: Magnus Damm Set the ->irq_enable() and ->irq_disable() methods to NULL to enable lazy disable of interrupts. Also extend the code to set IRQCHIP_MASK_ON_SUSPEND which tells the core that only IRQs marked as wakeups need to stay enabled during Suspend-to-RAM. Tested on the Lager board with