Re: [PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device

2017-12-05 Thread Nicolin Chen
On Tue, Dec 05, 2017 at 01:04:46PM +, Mark Brown wrote: > On Mon, Dec 04, 2017 at 12:46:34PM -0800, Nicolin Chen wrote: > > struct device is defined in system level header files any way. > > As long as fsl_ssi.h is included after those header files, it > > should be safe to remove this line. >

Re: [PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device

2017-12-05 Thread Mark Brown
On Mon, Dec 04, 2017 at 12:46:34PM -0800, Nicolin Chen wrote: > struct device is defined in system level header files any way. > As long as fsl_ssi.h is included after those header files, it > should be safe to remove this line. It's better practice to either directly include those headers or have

[PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device

2017-12-04 Thread Nicolin Chen
struct device is defined in system level header files any way. As long as fsl_ssi.h is included after those header files, it should be safe to remove this line. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.h b/