Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

2020-06-25 Thread Lee Jones
On Thu, 25 Jun 2020, Jonathan Corbet wrote: > On Thu, 25 Jun 2020 08:13:13 +0100 > Lee Jones wrote: > > > > Why are all of these documentation fixes for stable? > > > > Because they fix compiler warnings. > > > > Not correct? > > I am overjoyed to see people fixing docs build warnings, it is

Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

2020-06-25 Thread Lee Jones
On Thu, 25 Jun 2020, Greg KH wrote: > On Thu, Jun 25, 2020 at 08:13:13AM +0100, Lee Jones wrote: > > On Thu, 25 Jun 2020, Greg KH wrote: > > > > > On Thu, Jun 25, 2020 at 07:46:10AM +0100, Lee Jones wrote: > > > > Kerneldoc syntax is used, but not complete. Descriptions required. > > > > > > >

Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

2020-06-25 Thread Jonathan Corbet
On Thu, 25 Jun 2020 08:13:13 +0100 Lee Jones wrote: > > Why are all of these documentation fixes for stable? > > Because they fix compiler warnings. > > Not correct? I am overjoyed to see people fixing docs build warnings, it is work that is desperately needed. That said, these warning fixe

Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

2020-06-25 Thread Greg KH
On Thu, Jun 25, 2020 at 08:13:13AM +0100, Lee Jones wrote: > On Thu, 25 Jun 2020, Greg KH wrote: > > > On Thu, Jun 25, 2020 at 07:46:10AM +0100, Lee Jones wrote: > > > Kerneldoc syntax is used, but not complete. Descriptions required. > > > > > > Prevents warnings like: > > > > > > drivers/mfd

Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

2020-06-25 Thread Lee Jones
On Thu, 25 Jun 2020, Greg KH wrote: > On Thu, Jun 25, 2020 at 07:46:10AM +0100, Lee Jones wrote: > > Kerneldoc syntax is used, but not complete. Descriptions required. > > > > Prevents warnings like: > > > > drivers/mfd/wm8350-core.c:136: warning: Function parameter or member > > 'wm8350' not

Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

2020-06-24 Thread Greg KH
On Thu, Jun 25, 2020 at 07:46:10AM +0100, Lee Jones wrote: > Kerneldoc syntax is used, but not complete. Descriptions required. > > Prevents warnings like: > > drivers/mfd/wm8350-core.c:136: warning: Function parameter or member > 'wm8350' not described in 'wm8350_reg_lock' > drivers/mfd/wm83

[PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

2020-06-24 Thread Lee Jones
Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/mfd/wm8350-core.c:136: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_lock' drivers/mfd/wm8350-core.c:165: warning: Function parameter or member 'wm8350' not descri