Re: [PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values

2017-03-05 Thread Jiri Olsa
On Fri, Mar 03, 2017 at 03:16:11PM -0800, Andi Kleen wrote: > On Fri, Mar 03, 2017 at 11:33:03AM +0100, Jiri Olsa wrote: > > On Tue, Feb 28, 2017 at 10:49:15PM -0800, Andi Kleen wrote: > > > > SNIP > > > > > +static void collect_data(struct perf_evsel *counter, > > > + void (*

Re: [PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values

2017-03-03 Thread Andi Kleen
On Fri, Mar 03, 2017 at 11:33:03AM +0100, Jiri Olsa wrote: > On Tue, Feb 28, 2017 at 10:49:15PM -0800, Andi Kleen wrote: > > SNIP > > > +static void collect_data(struct perf_evsel *counter, > > + void (*cb)(struct perf_evsel *counter, void *data, > > +

Re: [PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values

2017-03-03 Thread Jiri Olsa
On Tue, Feb 28, 2017 at 10:49:15PM -0800, Andi Kleen wrote: SNIP > +static void collect_data(struct perf_evsel *counter, > + void (*cb)(struct perf_evsel *counter, void *data, > +bool first), > + void *data) > +{

[PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values

2017-02-28 Thread Andi Kleen
From: Andi Kleen To be used in next patch to support automatic summing of alias events. v2: Move check for bad results to next patch Signed-off-by: Andi Kleen --- tools/perf/builtin-stat.c | 104 -- 1 file changed, 81 insertions(+), 23 deletions(-)

Re: [PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values

2017-02-26 Thread Jiri Olsa
On Thu, Feb 23, 2017 at 04:10:12PM -0800, Andi Kleen wrote: SNIP > +static void aggr_cb(struct perf_evsel *counter, void *data, bool first) > +{ > + struct aggr_data *ad = data; > + int cpu, cpu2, s2; > + > + for (cpu = 0; cpu < perf_evsel__nr_cpus(counter); cpu++) { > + s

Re: [PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values

2017-02-24 Thread Andi Kleen
On Fri, Feb 24, 2017 at 09:37:20AM +0100, Jiri Olsa wrote: > On Thu, Feb 23, 2017 at 04:10:12PM -0800, Andi Kleen wrote: > > From: Andi Kleen > > > > To be used in next patch to support automatic summing of alias > > events. > > > > Signed-off-by: Andi Kleen > > hi, > I did not get the cover (

Re: [PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values

2017-02-24 Thread Jiri Olsa
On Thu, Feb 23, 2017 at 04:10:12PM -0800, Andi Kleen wrote: > From: Andi Kleen > > To be used in next patch to support automatic summing of alias > events. > > Signed-off-by: Andi Kleen hi, I did not get the cover (0/...) letter with changes history.. jirka

[PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values

2017-02-23 Thread Andi Kleen
From: Andi Kleen To be used in next patch to support automatic summing of alias events. Signed-off-by: Andi Kleen --- tools/perf/builtin-stat.c | 114 -- 1 file changed, 91 insertions(+), 23 deletions(-) diff --git a/tools/perf/builtin-stat.c b/tool