Re: [PATCH 01/10 v4] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-20 Thread Dmitry Torokhov
On Mon, Nov 20, 2017 at 8:29 AM, Russell King - ARM Linux wrote: > On Mon, Nov 20, 2017 at 09:56:21PM +0530, Arvind Yadav wrote: >> The platform_get_irq() function returns negative if an error occurs. >> zero or positive number on success. platform_get_irq() error checking

Re: [PATCH 01/10 v4] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-20 Thread Dmitry Torokhov
On Mon, Nov 20, 2017 at 8:29 AM, Russell King - ARM Linux wrote: > On Mon, Nov 20, 2017 at 09:56:21PM +0530, Arvind Yadav wrote: >> The platform_get_irq() function returns negative if an error occurs. >> zero or positive number on success. platform_get_irq() error checking >> for zero is not

Re: [PATCH 01/10 v4] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-20 Thread Russell King - ARM Linux
On Mon, Nov 20, 2017 at 09:56:21PM +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav > ---

Re: [PATCH 01/10 v4] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-20 Thread Russell King - ARM Linux
On Mon, Nov 20, 2017 at 09:56:21PM +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav > --- > changes in v2 : >

[PATCH 01/10 v4] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-20 Thread Arvind Yadav
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2 : Return keypad->irq insted of -ENXIO.

[PATCH 01/10 v4] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-20 Thread Arvind Yadav
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2 : Return keypad->irq insted of -ENXIO. changes in v3 : Add