Re: [PATCH 01/11] block_dev: Support checking inode permissions in lookup_bdev()

2017-12-23 Thread Dongsu Park
Hi, On Fri, Dec 22, 2017 at 7:59 PM, Coly Li wrote: > On 22/12/2017 10:32 PM, Dongsu Park wrote: > Hi Dongsu, > > Could you please use a macro like NO_PERMISSION_CHECK to replace hard > coded 0 ? At least for me, I don't need to check what does 0 mean in the > new lookup_bdev(). I see. I'll do t

Re: [PATCH 01/11] block_dev: Support checking inode permissions in lookup_bdev()

2017-12-22 Thread Serge E. Hallyn
On Fri, Dec 22, 2017 at 03:32:25PM +0100, Dongsu Park wrote: > From: Seth Forshee > > When looking up a block device by path no permission check is > done to verify that the user has access to the block device inode > at the specified path. In some cases it may be necessary to > check permissions

Re: [PATCH 01/11] block_dev: Support checking inode permissions in lookup_bdev()

2017-12-22 Thread Coly Li
On 22/12/2017 10:32 PM, Dongsu Park wrote: > From: Seth Forshee > > When looking up a block device by path no permission check is > done to verify that the user has access to the block device inode > at the specified path. In some cases it may be necessary to > check permissions towards the inode

[PATCH 01/11] block_dev: Support checking inode permissions in lookup_bdev()

2017-12-22 Thread Dongsu Park
From: Seth Forshee When looking up a block device by path no permission check is done to verify that the user has access to the block device inode at the specified path. In some cases it may be necessary to check permissions towards the inode, such as allowing unprivileged users to mount block de