Re: [PATCH 01/11] pagewalk: update page table walker core

2014-06-02 Thread Dave Hansen
On 02/10/2014 01:44 PM, Naoya Horiguchi wrote: > When we try to use multiple callbacks in different levels, skip control is > also important. For example we have thp enabled in normal configuration, and > we are interested in doing some work for a thp. But sometimes we want to > split it and handle

Re: [PATCH 01/11] pagewalk: update page table walker core

2014-02-21 Thread Sasha Levin
On 02/21/2014 11:35 AM, Naoya Horiguchi wrote: > On Fri, Feb 21, 2014 at 01:43:20AM -0500, Sasha Levin wrote: >> On 02/20/2014 10:20 PM, Naoya Horiguchi wrote: >>> Hi Sasha, >>> >>> On Thu, Feb 20, 2014 at 06:47:56PM -0500, Sasha Levin wrote: Hi Naoya, This patch seems to trigger a N

Re: [PATCH 01/11] pagewalk: update page table walker core

2014-02-20 Thread Sasha Levin
On 02/20/2014 10:20 PM, Naoya Horiguchi wrote: > Hi Sasha, > > On Thu, Feb 20, 2014 at 06:47:56PM -0500, Sasha Levin wrote: >> Hi Naoya, >> >> This patch seems to trigger a NULL ptr deref here. I didn't have a change to >> look into it yet >> but here's the spew: > > Thanks for reporting. > I'm

Re: [PATCH 01/11] pagewalk: update page table walker core

2014-02-20 Thread Sasha Levin
On 02/20/2014 06:47 PM, Sasha Levin wrote: Hi Naoya, This patch seems to trigger a NULL ptr deref here. I didn't have a change to look into it yet but here's the spew: [ 281.650503] BUG: unable to handle kernel NULL pointer dereference at 0018 [ 281.651577] IP: [] __lock_acquire

Re: [PATCH 01/11] pagewalk: update page table walker core

2014-02-20 Thread Sasha Levin
Hi Naoya, This patch seems to trigger a NULL ptr deref here. I didn't have a change to look into it yet but here's the spew: [ 281.650503] BUG: unable to handle kernel NULL pointer dereference at 0018 [ 281.651577] IP: [] __lock_acquire+0xbc/0x580 [ 281.652453] PGD 40b88d067 PUD

Re: [PATCH 01/11] pagewalk: update page table walker core

2014-02-11 Thread Joonsoo Kim
On Mon, Feb 10, 2014 at 04:44:26PM -0500, Naoya Horiguchi wrote: > This patch updates mm/pagewalk.c to make code less complex and more > maintenable. > The basic idea is unchanged and there's no userspace visible effect. > > Most of existing callback functions need access to vma to handle each en

[PATCH 01/11] pagewalk: update page table walker core

2014-02-10 Thread Naoya Horiguchi
This patch updates mm/pagewalk.c to make code less complex and more maintenable. The basic idea is unchanged and there's no userspace visible effect. Most of existing callback functions need access to vma to handle each entry. So we had better add a new member vma in struct mm_walk instead of usin

[PATCH 01/11] pagewalk: update page table walker core

2014-01-13 Thread Naoya Horiguchi
This patch updates mm/pagewalk.c to make code less complex and more maintenable. The basic idea is unchanged and there's no userspace visible effect. Most of existing callback functions need access to vma to handle each entry. So we had better add a new member vma in struct mm_walk instead of usin

Re: [PATCH 01/11] pagewalk: update page table walker core

2014-01-08 Thread Naoya Horiguchi
On Wed, Jan 08, 2014 at 03:48:29PM -0800, Andrew Morton wrote: > On Wed, 11 Dec 2013 17:08:57 -0500 Naoya Horiguchi > wrote: > > > This patch updates mm/pagewalk.c to make code less complex and more > > maintenable. > > The basic idea is unchanged and there's no userspace visible effect. > > >

Re: [PATCH 01/11] pagewalk: update page table walker core

2014-01-08 Thread Andrew Morton
On Wed, 11 Dec 2013 17:08:57 -0500 Naoya Horiguchi wrote: > This patch updates mm/pagewalk.c to make code less complex and more > maintenable. > The basic idea is unchanged and there's no userspace visible effect. > > Most of existing callback functions need access to vma to handle each entry.

[PATCH 01/11] pagewalk: update page table walker core

2013-12-11 Thread Naoya Horiguchi
This patch updates mm/pagewalk.c to make code less complex and more maintenable. The basic idea is unchanged and there's no userspace visible effect. Most of existing callback functions need access to vma to handle each entry. So we had better add a new member vma in struct mm_walk instead of usin

Re: [PATCH 01/11] pagewalk: update page table walker core

2013-10-31 Thread Naoya Horiguchi
On Wed, Oct 30, 2013 at 05:44:49PM -0400, Naoya Horiguchi wrote: ... > diff --git v3.12-rc7-mmots-2013-10-29-16-24.orig/mm/pagewalk.c > v3.12-rc7-mmots-2013-10-29-16-24/mm/pagewalk.c > index 2beeabf..af93846 100644 > --- v3.12-rc7-mmots-2013-10-29-16-24.orig/mm/pagewalk.c > +++ v3.12-rc7-mmots-201

[PATCH 01/11] pagewalk: update page table walker core

2013-10-30 Thread Naoya Horiguchi
This patch updates mm/pagewalk.c to make code less complex and more maintenable. The basic idea is unchanged and there's no userspace visible effect. Most of existing callback functions need access to vma to handle each entry. So we had better add a new member vma in struct mm_walk instead of usin

[PATCH 01/11] pagewalk: update page table walker core

2013-10-14 Thread Naoya Horiguchi
This patch updates mm/pagewalk.c to make code less complex and more maintenable. The basic idea is unchanged and there's no userspace visible effect. Most of existing callback functions need access to vma to handle each entry. So we had better add a new member vma in struct mm_walk instead of usin