Re: [PATCH 01/11] platform/x86: asus-wmi: Fix hwmon device cleanup

2019-04-12 Thread Yurii Pavlovskyi
Hello Daniel, thank you for the tip. I did not know about this function. It does indeed seem to make this complete patch redundant looking at 6e5f62b9e3651e61 hwmon: (lm90) Use devm_hwmon_device_register_with_groups I will surely implement it this way in the next version. Best regards, Yurii On

Re: [PATCH 01/11] platform/x86: asus-wmi: Fix hwmon device cleanup

2019-04-11 Thread Daniel Drake
On Thu, Apr 11, 2019 at 4:21 AM Yurii Pavlovskyi wrote: > > The asus-wmi driver does not clean up the hwmon device on exit or error. > To reproduce the bug, repeat rmmod, insmod to verify that device number > /sys/devices/platform/asus-nb-wmi/hwmon/hwmon?? grows every time. Add > pointer to the de

[PATCH 01/11] platform/x86: asus-wmi: Fix hwmon device cleanup

2019-04-10 Thread Yurii Pavlovskyi
The asus-wmi driver does not clean up the hwmon device on exit or error. To reproduce the bug, repeat rmmod, insmod to verify that device number /sys/devices/platform/asus-nb-wmi/hwmon/hwmon?? grows every time. Add pointer to the device in module state and call cleanup on error. Signed-off-by: Yur