On 23 September 2014 23:45, Greg KH wrote:
> On Thu, Sep 18, 2014 at 05:09:11PM -0600, Mathieu Poirier wrote:
>> On 12 September 2014 12:16, Greg KH wrote:
>> > On Fri, Sep 12, 2014 at 11:41:44AM -0600, Mathieu Poirier wrote:
>> >> Good morning and thanks for the review. Pls see comments below.
On 23 September 2014 23:45, Greg KH gre...@linuxfoundation.org wrote:
On Thu, Sep 18, 2014 at 05:09:11PM -0600, Mathieu Poirier wrote:
On 12 September 2014 12:16, Greg KH gre...@linuxfoundation.org wrote:
On Fri, Sep 12, 2014 at 11:41:44AM -0600, Mathieu Poirier wrote:
Good morning and
On Thu, Sep 18, 2014 at 05:09:11PM -0600, Mathieu Poirier wrote:
> On 12 September 2014 12:16, Greg KH wrote:
> > On Fri, Sep 12, 2014 at 11:41:44AM -0600, Mathieu Poirier wrote:
> >> Good morning and thanks for the review. Pls see comments below.
> >>
> >> Mathieu
> >>
> >> On 11 September 2014
On Thu, Sep 18, 2014 at 05:09:11PM -0600, Mathieu Poirier wrote:
On 12 September 2014 12:16, Greg KH gre...@linuxfoundation.org wrote:
On Fri, Sep 12, 2014 at 11:41:44AM -0600, Mathieu Poirier wrote:
Good morning and thanks for the review. Pls see comments below.
Mathieu
On 11
On 12 September 2014 12:16, Greg KH wrote:
> On Fri, Sep 12, 2014 at 11:41:44AM -0600, Mathieu Poirier wrote:
>> Good morning and thanks for the review. Pls see comments below.
>>
>> Mathieu
>>
>> On 11 September 2014 14:33, Greg KH wrote:
>> > Some first impressions in glancing at the code,
On 12 September 2014 12:16, Greg KH gre...@linuxfoundation.org wrote:
On Fri, Sep 12, 2014 at 11:41:44AM -0600, Mathieu Poirier wrote:
Good morning and thanks for the review. Pls see comments below.
Mathieu
On 11 September 2014 14:33, Greg KH gre...@linuxfoundation.org wrote:
Some first
On 12 September 2014 12:44, Russell King - ARM Linux
wrote:
> Further to Greg's comments...
>
> On Thu, Sep 11, 2014 at 09:49:08AM -0600, mathieu.poir...@linaro.org wrote:
>> +int coresight_enable(struct coresight_device *csdev)
>> +{
>> + int ret = 0;
>> + LIST_HEAD(path);
>> +
>> +
On 12 September 2014 12:44, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
Further to Greg's comments...
On Thu, Sep 11, 2014 at 09:49:08AM -0600, mathieu.poir...@linaro.org wrote:
+int coresight_enable(struct coresight_device *csdev)
+{
+ int ret = 0;
+ LIST_HEAD(path);
+
Further to Greg's comments...
On Thu, Sep 11, 2014 at 09:49:08AM -0600, mathieu.poir...@linaro.org wrote:
> +int coresight_enable(struct coresight_device *csdev)
> +{
> + int ret = 0;
> + LIST_HEAD(path);
> +
> + WARN_ON(IS_ERR_OR_NULL(csdev));
Please don't do this kind of checking,
On Fri, Sep 12, 2014 at 11:41:44AM -0600, Mathieu Poirier wrote:
> Good morning and thanks for the review. Pls see comments below.
>
> Mathieu
>
> On 11 September 2014 14:33, Greg KH wrote:
> > Some first impressions in glancing at the code, not a complete review at
> > all:
> >
> > On Thu,
Good morning and thanks for the review. Pls see comments below.
Mathieu
On 11 September 2014 14:33, Greg KH wrote:
> Some first impressions in glancing at the code, not a complete review at
> all:
>
> On Thu, Sep 11, 2014 at 09:49:08AM -0600, mathieu.poir...@linaro.org wrote:
>> --- /dev/null
Good morning and thanks for the review. Pls see comments below.
Mathieu
On 11 September 2014 14:33, Greg KH gre...@linuxfoundation.org wrote:
Some first impressions in glancing at the code, not a complete review at
all:
On Thu, Sep 11, 2014 at 09:49:08AM -0600, mathieu.poir...@linaro.org
On Fri, Sep 12, 2014 at 11:41:44AM -0600, Mathieu Poirier wrote:
Good morning and thanks for the review. Pls see comments below.
Mathieu
On 11 September 2014 14:33, Greg KH gre...@linuxfoundation.org wrote:
Some first impressions in glancing at the code, not a complete review at
all:
Further to Greg's comments...
On Thu, Sep 11, 2014 at 09:49:08AM -0600, mathieu.poir...@linaro.org wrote:
+int coresight_enable(struct coresight_device *csdev)
+{
+ int ret = 0;
+ LIST_HEAD(path);
+
+ WARN_ON(IS_ERR_OR_NULL(csdev));
Please don't do this kind of checking, it
Some first impressions in glancing at the code, not a complete review at
all:
On Thu, Sep 11, 2014 at 09:49:08AM -0600, mathieu.poir...@linaro.org wrote:
> --- /dev/null
> +++ b/drivers/coresight/coresight.c
> @@ -0,0 +1,663 @@
> +/* Copyright (c) 2012, The Linux Foundation. All rights reserved.
From: Pratik Patel
CoreSight components are compliant with the ARM CoreSight
architecture specification and can be connected in various
topologies to suit a particular SoC tracing needs. These trace
components can generally be classified as sources, links and
sinks. Trace data produced by one or
From: Pratik Patel prat...@codeaurora.org
CoreSight components are compliant with the ARM CoreSight
architecture specification and can be connected in various
topologies to suit a particular SoC tracing needs. These trace
components can generally be classified as sources, links and
sinks. Trace
Some first impressions in glancing at the code, not a complete review at
all:
On Thu, Sep 11, 2014 at 09:49:08AM -0600, mathieu.poir...@linaro.org wrote:
--- /dev/null
+++ b/drivers/coresight/coresight.c
@@ -0,0 +1,663 @@
+/* Copyright (c) 2012, The Linux Foundation. All rights reserved.
+ *
18 matches
Mail list logo
