Re: [PATCH 01/12] ping.h: Remove extern from function prototypes

2013-09-22 Thread David Miller
Series applied, thanks Joe. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 01/12] ping.h: Remove extern from function prototypes

2013-09-22 Thread Joe Perches
On Mon, 2013-09-23 at 12:38 +1000, Ryan Mallon wrote: > A checkpatch rule might help, Extant. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH 01/12] ping.h: Remove extern from function prototypes

2013-09-22 Thread Ryan Mallon
On 23/09/13 12:16, Joe Perches wrote: > On Mon, 2013-09-23 at 11:59 +1000, Ryan Mallon wrote: >> This seems like a lot of code churn for very little benefit. At a quick >> glance: >> >> git grep extern include/ | wc -l >> 11427 >> >> Not all of those will need to be removed, but that is still a

Re: [PATCH 01/12] ping.h: Remove extern from function prototypes

2013-09-22 Thread Joe Perches
On Mon, 2013-09-23 at 11:59 +1000, Ryan Mallon wrote: > This seems like a lot of code churn for very little benefit. At a quick > glance: > > git grep extern include/ | wc -l > 11427 > > Not all of those will need to be removed, but that is still a huge > number to change, and doesn't include

Re: [PATCH 01/12] ping.h: Remove extern from function prototypes

2013-09-22 Thread Ryan Mallon
On 23/09/13 03:32, Joe Perches wrote: > There are a mix of function prototypes with and without extern > in the kernel sources. Standardize on not using extern for > function prototypes. > > Function prototypes don't need to be written with extern. > extern is assumed by the compiler. Its use is

[PATCH 01/12] ping.h: Remove extern from function prototypes

2013-09-22 Thread Joe Perches
There are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes. Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic