Re: [PATCH 01/15] ARM: actions: fix a leaked reference by addingmissing of_node_put

2019-03-05 Thread Russell King - ARM Linux admin
On Tue, Mar 05, 2019 at 07:21:19AM +0530, Manivannan Sadhasivam wrote: > On Tue, 5 Mar, 2019, 4:08 AM Linus Walleij > > On Mon, Mar 4, 2019 at 3:48 PM Manivannan Sadhasivam > > wrote: > > > On Mon, Mar 04, 2019 at 01:29:33PM +0100, Linus Walleij wrote: > > > > On Fri, Mar 1, 2019 at 4:55 PM

Re: [PATCH 01/15] ARM: actions: fix a leaked reference by addingmissing of_node_put

2019-03-04 Thread Linus Walleij
On Mon, Mar 4, 2019 at 3:48 PM Manivannan Sadhasivam wrote: > On Mon, Mar 04, 2019 at 01:29:33PM +0100, Linus Walleij wrote: > > On Fri, Mar 1, 2019 at 4:55 PM Manivannan Sadhasivam > > wrote: > > > Hi Wen, > > > > > > On Fri, Mar 01, 2019 at 04:56:42PM +0800, Wen Yang wrote: > > > > The call to

Re: [PATCH 01/15] ARM: actions: fix a leaked reference by addingmissing of_node_put

2019-03-04 Thread Manivannan Sadhasivam
Hi Linus, On Mon, Mar 04, 2019 at 01:29:33PM +0100, Linus Walleij wrote: > On Fri, Mar 1, 2019 at 4:55 PM Manivannan Sadhasivam > wrote: > > Hi Wen, > > > > On Fri, Mar 01, 2019 at 04:56:42PM +0800, Wen Yang wrote: > > > The call to of_get_next_child returns a node pointer with refcount > > >

Re: [PATCH 01/15] ARM: actions: fix a leaked reference by addingmissing of_node_put

2019-03-04 Thread Linus Walleij
On Fri, Mar 1, 2019 at 4:55 PM Manivannan Sadhasivam wrote: > Hi Wen, > > On Fri, Mar 01, 2019 at 04:56:42PM +0800, Wen Yang wrote: > > The call to of_get_next_child returns a node pointer with refcount > > incremented thus it must be explicitly decremented after the last > > usage. > > > >

Re: [PATCH 01/15] ARM: actions: fix a leaked reference by addingmissing of_node_put

2019-03-01 Thread Manivannan Sadhasivam
Hi Wen, On Fri, Mar 01, 2019 at 04:56:42PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: >

[PATCH 01/15] ARM: actions: fix a leaked reference by addingmissing of_node_put

2019-03-01 Thread Wen Yang
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./arch/arm/mach-actions/platsmp.c:112:2-8: ERROR: missing of_node_put; acquired a node pointer with