Re: [PATCH 01/16] devpts: Attempting to get it right

2016-04-19 Thread Peter Hurley
On 04/19/2016 05:24 PM, Peter Hurley wrote: > On 04/19/2016 04:35 PM, Linus Torvalds wrote: >> On Tue, Apr 19, 2016 at 3:06 PM, Eric W. Biederman >> wrote: >>> >>> I have work inspired by this rolled into my code. I will post shortly >>> after a little more testing. >> >> Actually, I have a sligh

Re: [PATCH 01/16] devpts: Attempting to get it right

2016-04-19 Thread Peter Hurley
On 04/19/2016 04:35 PM, Linus Torvalds wrote: > On Tue, Apr 19, 2016 at 3:06 PM, Eric W. Biederman > wrote: >> >> I have work inspired by this rolled into my code. I will post shortly >> after a little more testing. > > Actually, I have a slightly fixed version in my tree. I've been > running th

Re: [PATCH 01/16] devpts: Attempting to get it right

2016-04-19 Thread Linus Torvalds
On Tue, Apr 19, 2016 at 3:06 PM, Eric W. Biederman wrote: > > I have work inspired by this rolled into my code. I will post shortly > after a little more testing. Actually, I have a slightly fixed version in my tree. I've been running this on my own machines for a few days, just to verify, along

Re: [PATCH 01/16] devpts: Attempting to get it right

2016-04-19 Thread Eric W. Biederman
Linus Torvalds writes: > So I've looked at the devpts patches some more, and I'm still not happy > with them. > > And one thing I really detest about them is that the 16-patch series > didn't really make me warm and fuzzy in general. Some of the patches were > fine, but on the whole it all sti

Re: [PATCH 01/16] devpts: Attempting to get it right

2016-04-19 Thread Eric W. Biederman
"H. Peter Anvin" writes: > It's really too bad we can't just use follow_link :-/ Well follow_link is actually impossible to use as it doesn't exist anymore. The routine now is get_link. ;-) That said just to be certain of where everything stands I took a look to verify that we can't. I got ab

Re: [PATCH 01/16] devpts: Attempting to get it right

2016-04-16 Thread Linus Torvalds
So I've looked at the devpts patches some more, and I'm still not happy with them. And one thing I really detest about them is that the 16-patch series didn't really make me warm and fuzzy in general. Some of the patches were fine, but on the whole it all still looked rather hacky. So I start

Re: [PATCH 01/16] devpts: Attempting to get it right

2016-04-15 Thread H. Peter Anvin
It's really too bad we can't just use follow_link :-/ -- Sent from my Android device with K-9 Mail. Please excuse brevity and formatting.

Re: [PATCH 01/16] devpts: Attempting to get it right

2016-04-15 Thread Eric W. Biederman
Andy Lutomirski writes: > On Fri, Apr 15, 2016 at 8:34 AM, Eric W. Biederman > wrote: >> >> To recap the situation for those who have not been following closely. >> >> There are programs such as xen-create-image that run as root and setup >> a chroot environment with: >> "mknod dev/ptmx c 5 2" >

Re: [PATCH 01/16] devpts: Attempting to get it right

2016-04-15 Thread Andy Lutomirski
On Fri, Apr 15, 2016 at 8:34 AM, Eric W. Biederman wrote: > > To recap the situation for those who have not been following closely. > > There are programs such as xen-create-image that run as root and setup > a chroot environment with: > "mknod dev/ptmx c 5 2" > "mkdir dev/pts" > "mount -t devpts

[PATCH 01/16] devpts: Attempting to get it right

2016-04-15 Thread Eric W. Biederman
To recap the situation for those who have not been following closely. There are programs such as xen-create-image that run as root and setup a chroot environment with: "mknod dev/ptmx c 5 2" "mkdir dev/pts" "mount -t devpts none dev/pts" Which mostly works but stomps the mount options of the sys