Re: [PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit

2016-07-15 Thread Steve Longerbeam
On 07/10/2016 05:02 PM, Paul Gortmaker wrote: +#include +#include You have a u32 field in a struct called "modules" but aside from that, I do not see anything in this code requiring module.h -- did I miss something? You might want export.h for EXPORT_SYMBOL though. Hi Paul, yes

Re: [PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit

2016-07-15 Thread Steve Longerbeam
On 07/10/2016 05:02 PM, Paul Gortmaker wrote: +#include +#include You have a u32 field in a struct called "modules" but aside from that, I do not see anything in this code requiring module.h -- did I miss something? You might want export.h for EXPORT_SYMBOL though. Hi Paul, yes

Re: [PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit

2016-07-10 Thread Paul Gortmaker
On Thu, Jul 7, 2016 at 7:03 PM, Steve Longerbeam wrote: > Adds the Video Deinterlacer (VDIC) unit. > > Signed-off-by: Steve Longerbeam > --- > drivers/gpu/ipu-v3/Makefile | 2 +- > drivers/gpu/ipu-v3/ipu-common.c | 11 ++ >

Re: [PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit

2016-07-10 Thread Paul Gortmaker
On Thu, Jul 7, 2016 at 7:03 PM, Steve Longerbeam wrote: > Adds the Video Deinterlacer (VDIC) unit. > > Signed-off-by: Steve Longerbeam > --- > drivers/gpu/ipu-v3/Makefile | 2 +- > drivers/gpu/ipu-v3/ipu-common.c | 11 ++ > drivers/gpu/ipu-v3/ipu-prv.h| 6 + >

[PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit

2016-07-07 Thread Steve Longerbeam
Adds the Video Deinterlacer (VDIC) unit. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/Makefile | 2 +- drivers/gpu/ipu-v3/ipu-common.c | 11 ++ drivers/gpu/ipu-v3/ipu-prv.h| 6 + drivers/gpu/ipu-v3/ipu-vdi.c| 266

[PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit

2016-07-07 Thread Steve Longerbeam
Adds the Video Deinterlacer (VDIC) unit. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/Makefile | 2 +- drivers/gpu/ipu-v3/ipu-common.c | 11 ++ drivers/gpu/ipu-v3/ipu-prv.h| 6 + drivers/gpu/ipu-v3/ipu-vdi.c| 266