Re: [PATCH 01/17] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2019-01-25 Thread Nadav Amit
> On Jan 25, 2019, at 1:30 AM, Borislav Petkov wrote: > > On Wed, Jan 16, 2019 at 04:32:43PM -0800, Rick Edgecombe wrote: >> From: Nadav Amit >> >> text_mutex is currently expected to be held before text_poke() is >> called, but we kgdb does not take the mutex, and instead *supposedly* >>

Re: [PATCH 01/17] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2019-01-25 Thread Borislav Petkov
On Wed, Jan 16, 2019 at 04:32:43PM -0800, Rick Edgecombe wrote: > From: Nadav Amit > > text_mutex is currently expected to be held before text_poke() is > called, but we kgdb does not take the mutex, and instead *supposedly* > ensures the lock is not taken and will not be acquired by any other

Re: [PATCH 01/17] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2019-01-17 Thread Nadav Amit
> On Jan 17, 2019, at 2:59 PM, h...@zytor.com wrote: > > On January 17, 2019 2:39:15 PM PST, Nadav Amit wrote: >>> On Jan 17, 2019, at 1:15 PM, h...@zytor.com wrote: >>> >>> On January 16, 2019 10:47:01 PM PST, Masami Hiramatsu >> wrote: On Wed, 16 Jan 2019 16:32:43 -0800 Rick

Re: [PATCH 01/17] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2019-01-17 Thread hpa
On January 17, 2019 2:39:15 PM PST, Nadav Amit wrote: >> On Jan 17, 2019, at 1:15 PM, h...@zytor.com wrote: >> >> On January 16, 2019 10:47:01 PM PST, Masami Hiramatsu > wrote: >>> On Wed, 16 Jan 2019 16:32:43 -0800 >>> Rick Edgecombe wrote: >>> From: Nadav Amit text_mutex is

Re: [PATCH 01/17] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2019-01-17 Thread Nadav Amit
> On Jan 17, 2019, at 1:15 PM, h...@zytor.com wrote: > > On January 16, 2019 10:47:01 PM PST, Masami Hiramatsu > wrote: >> On Wed, 16 Jan 2019 16:32:43 -0800 >> Rick Edgecombe wrote: >> >>> From: Nadav Amit >>> >>> text_mutex is currently expected to be held before text_poke() is >>>

Re: [PATCH 01/17] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2019-01-17 Thread hpa
On January 16, 2019 10:47:01 PM PST, Masami Hiramatsu wrote: >On Wed, 16 Jan 2019 16:32:43 -0800 >Rick Edgecombe wrote: > >> From: Nadav Amit >> >> text_mutex is currently expected to be held before text_poke() is >> called, but we kgdb does not take the mutex, and instead *supposedly* >>

Re: [PATCH 01/17] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2019-01-16 Thread Masami Hiramatsu
On Wed, 16 Jan 2019 16:32:43 -0800 Rick Edgecombe wrote: > From: Nadav Amit > > text_mutex is currently expected to be held before text_poke() is > called, but we kgdb does not take the mutex, and instead *supposedly* > ensures the lock is not taken and will not be acquired by any other core >

[PATCH 01/17] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2019-01-16 Thread Rick Edgecombe
From: Nadav Amit text_mutex is currently expected to be held before text_poke() is called, but we kgdb does not take the mutex, and instead *supposedly* ensures the lock is not taken and will not be acquired by any other core while text_poke() is running. The reason for the "supposedly" comment