Re: [PATCH 01/17] cgroup: remove incorrect dget/dput() pair in cgroup_create_dir()

2012-11-19 Thread Tejun Heo
On Mon, Nov 19, 2012 at 04:08:04PM +0800, Li Zefan wrote: > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > > index 0f8fa6a..d0803f0 100644 > > --- a/kernel/cgroup.c > > +++ b/kernel/cgroup.c > > @@ -2684,9 +2684,7 @@ static int cgroup_create_dir(struct cgroup *cgrp, > > struct dentry *dentry,

Re: [PATCH 01/17] cgroup: remove incorrect dget/dput() pair in cgroup_create_dir()

2012-11-19 Thread Li Zefan
On 2012/11/13 11:01, Tejun Heo wrote: > cgroup_create_dir() does weird dancing with dentry refcnt. On > success, it gets and then puts it achieving nothing. On failure, it > puts but there isn't no matching get anywhere leading to the following > oops if cgroup_create_file() fails for whatever

Re: [PATCH 01/17] cgroup: remove incorrect dget/dput() pair in cgroup_create_dir()

2012-11-19 Thread Li Zefan
On 2012/11/13 11:01, Tejun Heo wrote: cgroup_create_dir() does weird dancing with dentry refcnt. On success, it gets and then puts it achieving nothing. On failure, it puts but there isn't no matching get anywhere leading to the following oops if cgroup_create_file() fails for whatever

Re: [PATCH 01/17] cgroup: remove incorrect dget/dput() pair in cgroup_create_dir()

2012-11-19 Thread Tejun Heo
On Mon, Nov 19, 2012 at 04:08:04PM +0800, Li Zefan wrote: diff --git a/kernel/cgroup.c b/kernel/cgroup.c index 0f8fa6a..d0803f0 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ -2684,9 +2684,7 @@ static int cgroup_create_dir(struct cgroup *cgrp, struct dentry *dentry,

[PATCH 01/17] cgroup: remove incorrect dget/dput() pair in cgroup_create_dir()

2012-11-12 Thread Tejun Heo
cgroup_create_dir() does weird dancing with dentry refcnt. On success, it gets and then puts it achieving nothing. On failure, it puts but there isn't no matching get anywhere leading to the following oops if cgroup_create_file() fails for whatever reason. [ cut here ]

[PATCH 01/17] cgroup: remove incorrect dget/dput() pair in cgroup_create_dir()

2012-11-12 Thread Tejun Heo
cgroup_create_dir() does weird dancing with dentry refcnt. On success, it gets and then puts it achieving nothing. On failure, it puts but there isn't no matching get anywhere leading to the following oops if cgroup_create_file() fails for whatever reason. [ cut here ]