Re: [PATCH 01/17] mm/highmem: Lift memcpy_[to|from]_page and memset_page to core

2020-12-03 Thread Ira Weiny
On Mon, Nov 30, 2020 at 11:22:32AM +0200, Joonas Lahtinen wrote: > Quoting Matthew Wilcox (2020-11-27 15:20:06) > > On Fri, Nov 27, 2020 at 03:06:24PM +0200, Joonas Lahtinen wrote: > > > Quoting ira.we...@intel.com (2020-11-24 08:07:39) > > > > From: Ira Weiny > > > > > > > > Working through a

Re: [PATCH 01/17] mm/highmem: Lift memcpy_[to|from]_page and memset_page to core

2020-11-27 Thread Matthew Wilcox
On Fri, Nov 27, 2020 at 03:06:24PM +0200, Joonas Lahtinen wrote: > Quoting ira.we...@intel.com (2020-11-24 08:07:39) > > From: Ira Weiny > > > > Working through a conversion to a call such as kmap_thread() revealed > > many places where the pattern kmap/memcpy/kunmap occurred. > > > > Eric

Re: [PATCH 01/17] mm/highmem: Lift memcpy_[to|from]_page and memset_page to core

2020-11-24 Thread Matthew Wilcox
On Tue, Nov 24, 2020 at 11:21:13AM -0800, Ira Weiny wrote: > On Tue, Nov 24, 2020 at 02:19:41PM +, Matthew Wilcox wrote: > > On Mon, Nov 23, 2020 at 10:07:39PM -0800, ira.we...@intel.com wrote: > > > +static inline void memzero_page(struct page *page, size_t offset, size_t > > > len) > > > +{

Re: [PATCH 01/17] mm/highmem: Lift memcpy_[to|from]_page and memset_page to core

2020-11-24 Thread Ira Weiny
On Tue, Nov 24, 2020 at 02:19:41PM +, Matthew Wilcox wrote: > On Mon, Nov 23, 2020 at 10:07:39PM -0800, ira.we...@intel.com wrote: > > +static inline void memzero_page(struct page *page, size_t offset, size_t > > len) > > +{ > > + memset_page(page, 0, offset, len); > > +} > > This is a

Re: [PATCH 01/17] mm/highmem: Lift memcpy_[to|from]_page and memset_page to core

2020-11-24 Thread Matthew Wilcox
On Mon, Nov 23, 2020 at 10:07:39PM -0800, ira.we...@intel.com wrote: > +static inline void memzero_page(struct page *page, size_t offset, size_t len) > +{ > + memset_page(page, 0, offset, len); > +} This is a less-capable zero_user_segments().

[PATCH 01/17] mm/highmem: Lift memcpy_[to|from]_page and memset_page to core

2020-11-23 Thread ira . weiny
From: Ira Weiny Working through a conversion to a call such as kmap_thread() revealed many places where the pattern kmap/memcpy/kunmap occurred. Eric Biggers, Matthew Wilcox, Christoph Hellwig, Dan Williams, and Al Viro all suggested putting this code into helper functions. Al Viro further