Re: [PATCH 01/17] x86: spec_ctrl: fix SPEC_CTRL initialization after kexec

2019-09-23 Thread Sean Christopherson
On Mon, Sep 23, 2019 at 01:34:21PM -0400, Andrea Arcangeli wrote: > Per subject of the patch, 14 is also an optimization that while not a > strict requirement, is somewhat related to the monolithic conversion > because in fact it may naturally disappear if I rename the vmx/svm > functions

Re: [PATCH 01/17] x86: spec_ctrl: fix SPEC_CTRL initialization after kexec

2019-09-23 Thread Andrea Arcangeli
Hello, On Mon, Sep 23, 2019 at 08:30:57AM -0700, Sean Christopherson wrote: > On Mon, Sep 23, 2019 at 12:22:23PM +0200, Paolo Bonzini wrote: > > On 20/09/19 23:24, Andrea Arcangeli wrote: > > > We can't assume the SPEC_CTRL msr is zero at boot because it could be > > > left enabled by a previous

Re: [PATCH 01/17] x86: spec_ctrl: fix SPEC_CTRL initialization after kexec

2019-09-23 Thread Sean Christopherson
On Mon, Sep 23, 2019 at 12:22:23PM +0200, Paolo Bonzini wrote: > On 20/09/19 23:24, Andrea Arcangeli wrote: > > We can't assume the SPEC_CTRL msr is zero at boot because it could be > > left enabled by a previous kernel booted with > > spec_store_bypass_disable=on. > > > > Without this fix a boot

Re: [PATCH 01/17] x86: spec_ctrl: fix SPEC_CTRL initialization after kexec

2019-09-23 Thread Paolo Bonzini
On 20/09/19 23:24, Andrea Arcangeli wrote: > We can't assume the SPEC_CTRL msr is zero at boot because it could be > left enabled by a previous kernel booted with > spec_store_bypass_disable=on. > > Without this fix a boot with spec_store_bypass_disable=on followed by > a kexec boot with

[PATCH 01/17] x86: spec_ctrl: fix SPEC_CTRL initialization after kexec

2019-09-20 Thread Andrea Arcangeli
We can't assume the SPEC_CTRL msr is zero at boot because it could be left enabled by a previous kernel booted with spec_store_bypass_disable=on. Without this fix a boot with spec_store_bypass_disable=on followed by a kexec boot with spec_store_bypass_disable=off would erroneously and