[PATCH 01/19] perf metric: Fix memory leak in expr__add_id function

2020-07-29 Thread Jiri Olsa
Arnaldo found that we don't release value data in case the hashmap__set fails. Releasing it in case of an error. Reported-by: Arnaldo Carvalho de Melo Signed-off-by: Jiri Olsa Acked-by: Ian Rogers Cc: Alexander Shishkin Cc: Andi Kleen Cc: John Garry Cc: Kajol Jain Cc: Michael Petlan Cc: Na

Re: [PATCH 01/19] perf metric: Fix memory leak in expr__add_id function

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 19, 2020 at 02:41:46PM -0700, Ian Rogers escreveu: > On Sun, Jul 19, 2020 at 11:13 AM Jiri Olsa wrote: > > > > Arnaldo found that we don't release value data in case the > > hashmap__set fails. Releasing it in case of an error. > > > > Reported-by: Arnaldo Carvalho de Melo > > Signed-

Re: [PATCH 01/19] perf metric: Fix memory leak in expr__add_id function

2020-07-19 Thread Ian Rogers
On Sun, Jul 19, 2020 at 11:13 AM Jiri Olsa wrote: > > Arnaldo found that we don't release value data in case the > hashmap__set fails. Releasing it in case of an error. > > Reported-by: Arnaldo Carvalho de Melo > Signed-off-by: Jiri Olsa Acked-by: Ian Rogers > --- > tools/perf/util/expr.c |

[PATCH 01/19] perf metric: Fix memory leak in expr__add_id function

2020-07-19 Thread Jiri Olsa
Arnaldo found that we don't release value data in case the hashmap__set fails. Releasing it in case of an error. Reported-by: Arnaldo Carvalho de Melo Signed-off-by: Jiri Olsa --- tools/perf/util/expr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/expr.c b/tools/perf/ut