Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

2015-06-02 Thread Jacek Anaszewski
On 06/01/2015 04:37 PM, Stas Sergeev wrote: 01.06.2015 17:19, Jacek Anaszewski пишет: In fact, the things are more complicated: some drivers do small udelay()'s but do not use a work-queue. I was not marking them as FAST, although perhaps they could still be marked as SYNC? This could be handle

Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

2015-06-01 Thread Stas Sergeev
01.06.2015 17:19, Jacek Anaszewski пишет: >> In fact, the things are more complicated: some drivers do small >> udelay()'s but do not use a work-queue. I was not marking them as >> FAST, although perhaps they could still be marked as SYNC? > This could be handled by adding a property to struct led_

Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

2015-06-01 Thread Jacek Anaszewski
On 06/01/2015 01:56 PM, Stas Sergeev wrote: 01.06.2015 11:31, Jacek Anaszewski пишет: With this approach, the LED will remain in its current blink state, in case LED_BRIGHTNESS_FAST flag is not set and delay to be set is below LED_SLOW_MIN_PERIOD. This is because timer is deleted at the beginni

Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

2015-06-01 Thread Stas Sergeev
01.06.2015 11:31, Jacek Anaszewski пишет: > With this approach, the LED will remain in its current blink state, in > case LED_BRIGHTNESS_FAST flag is not set and delay to be set is below > LED_SLOW_MIN_PERIOD. This is because timer is deleted at the beginning > of led_blink_set. Effectively this c

Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

2015-06-01 Thread Jacek Anaszewski
On 05/20/2015 05:19 PM, Stas Sergeev wrote: Add LED_BRIGHTNESS_FAST flag. This flag is used to mark the led drivers that do not use waiting operations when setting led brightness and do not use work-queue in .brightness_set op. When this flag is not set, disallow the blink periods smaller than 1

Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

2015-05-29 Thread Stas Sergeev
21.05.2015 18:26, Stas Sergeev пишет: > 21.05.2015 16:37, Jacek Anaszewski пишет: >> On 05/21/2015 03:27 PM, Stas Sergeev wrote: >>> 21.05.2015 16:22, Jacek Anaszewski пишет: Hi Stas, My intention was to add a developer of each driver on cc in the commit message. >>> I did. You

Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

2015-05-21 Thread Stas Sergeev
21.05.2015 16:37, Jacek Anaszewski пишет: > On 05/21/2015 03:27 PM, Stas Sergeev wrote: >> 21.05.2015 16:22, Jacek Anaszewski пишет: >>> Hi Stas, >>> >>> My intention was to add a developer of each driver on >>> cc in the commit message. >> I did. You can see CC: Chris Boot at patch 12. >> Otherwi

Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

2015-05-21 Thread Jacek Anaszewski
On 05/21/2015 03:27 PM, Stas Sergeev wrote: 21.05.2015 16:22, Jacek Anaszewski пишет: Hi Stas, My intention was to add a developer of each driver on cc in the commit message. I did. You can see CC: Chris Boot at patch 12. Otherwise, this is all the get_maintainers.pl script gives me. So unles

Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

2015-05-21 Thread Stas Sergeev
21.05.2015 16:22, Jacek Anaszewski пишет: > Hi Stas, > > My intention was to add a developer of each driver on > cc in the commit message. I did. You can see CC: Chris Boot at patch 12. Otherwise, this is all the get_maintainers.pl script gives me. So unless you can suggest some other script, or

Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

2015-05-21 Thread Jacek Anaszewski
Hi Stas, My intention was to add a developer of each driver on cc in the commit message. This way authors of drivers that you classified as the fast ones could provide us with the feedback in case there were some non-obvious obstacles preventing the drivers from setting the brightness with high f

[PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

2015-05-20 Thread Stas Sergeev
Add LED_BRIGHTNESS_FAST flag. This flag is used to mark the led drivers that do not use waiting operations when setting led brightness and do not use work-queue in .brightness_set op. When this flag is not set, disallow the blink periods smaller than 10mS (LED_SLOW_MIN_PERIOD define). CC: Bryan W