Re: [PATCH 01/21] acpi: Print Hot-Pluggable Field in SRAT.

2013-07-23 Thread Tang Chen
On 07/24/2013 02:48 AM, Tejun Heo wrote: On Fri, Jul 19, 2013 at 03:59:14PM +0800, Tang Chen wrote: The Hot-Pluggable field in SRAT suggests if the memory could be hotplugged while the system is running. Print it as well when parsing SRAT will help users to know which memory is hotpluggable. Si

Re: [PATCH 01/21] acpi: Print Hot-Pluggable Field in SRAT.

2013-07-23 Thread Joe Perches
On Tue, 2013-07-23 at 15:20 -0400, Tejun Heo wrote: > On Tue, Jul 23, 2013 at 12:15:58PM -0700, Joe Perches wrote: [] > > so there's no space before newline. > Which was my first point which apparently wasn't clear enough. :) Nah, I just constantly need to relearn how to read... -- To unsubscribe

Re: [PATCH 01/21] acpi: Print Hot-Pluggable Field in SRAT.

2013-07-23 Thread Tejun Heo
On Tue, Jul 23, 2013 at 12:15:58PM -0700, Joe Perches wrote: > > The following would be more conventional. > > > > "...10Lx]%s\n", ..., hotpluggable ? " Hot Pluggable" : "" > > > > Also, isn't "Hot Pluggable" a bit too verbose? "hotplug" should be > > fine, I think. > > It's also a tiny nit b

Re: [PATCH 01/21] acpi: Print Hot-Pluggable Field in SRAT.

2013-07-23 Thread Joe Perches
On Tue, 2013-07-23 at 14:48 -0400, Tejun Heo wrote: > On Fri, Jul 19, 2013 at 03:59:14PM +0800, Tang Chen wrote: > > The Hot-Pluggable field in SRAT suggests if the memory could be > > hotplugged while the system is running. Print it as well when > > parsing SRAT will help users to know which memor

Re: [PATCH 01/21] acpi: Print Hot-Pluggable Field in SRAT.

2013-07-23 Thread Tejun Heo
On Fri, Jul 19, 2013 at 03:59:14PM +0800, Tang Chen wrote: > The Hot-Pluggable field in SRAT suggests if the memory could be > hotplugged while the system is running. Print it as well when > parsing SRAT will help users to know which memory is hotpluggable. > > Signed-off-by: Tang Chen > Reviewed

[PATCH 01/21] acpi: Print Hot-Pluggable Field in SRAT.

2013-07-19 Thread Tang Chen
The Hot-Pluggable field in SRAT suggests if the memory could be hotplugged while the system is running. Print it as well when parsing SRAT will help users to know which memory is hotpluggable. Signed-off-by: Tang Chen Reviewed-by: Wanpeng Li --- arch/x86/mm/srat.c | 11 +++ 1 files ch