Re: [PATCH 01/28] PCI: Rip out pci_bus_add_devices() from pci_scan_bus()

2015-01-19 Thread Arnd Bergmann
On Friday 16 January 2015 15:16:28 Yinghai Lu wrote: > On Fri, Jan 16, 2015 at 3:15 PM, Yinghai Lu wrote: > > On Thu, Jan 15, 2015 at 5:43 PM, Yijing Wang wrote: > >> Pci_bus_add_devices() should not be placed in pci_scan_bus(). > >> Now pci device will be added to driver core once its > >> creat

Re: [PATCH 01/28] PCI: Rip out pci_bus_add_devices() from pci_scan_bus()

2015-01-18 Thread Greg Ungerer
On 19/01/15 12:04, Yijing Wang wrote: > On 2015/1/17 7:16, Yinghai Lu wrote: >> On Fri, Jan 16, 2015 at 3:15 PM, Yinghai Lu wrote: >>> On Thu, Jan 15, 2015 at 5:43 PM, Yijing Wang wrote: Pci_bus_add_devices() should not be placed in pci_scan_bus(). Now pci device will be added to driver

Re: [PATCH 01/28] PCI: Rip out pci_bus_add_devices() from pci_scan_bus()

2015-01-18 Thread Yijing Wang
On 2015/1/17 7:16, Yinghai Lu wrote: > On Fri, Jan 16, 2015 at 3:15 PM, Yinghai Lu wrote: >> On Thu, Jan 15, 2015 at 5:43 PM, Yijing Wang wrote: >>> Pci_bus_add_devices() should not be placed in pci_scan_bus(). >>> Now pci device will be added to driver core once its >>> creation. All things left

Re: [PATCH 01/28] PCI: Rip out pci_bus_add_devices() from pci_scan_bus()

2015-01-16 Thread Yinghai Lu
On Fri, Jan 16, 2015 at 3:15 PM, Yinghai Lu wrote: > On Thu, Jan 15, 2015 at 5:43 PM, Yijing Wang wrote: >> Pci_bus_add_devices() should not be placed in pci_scan_bus(). >> Now pci device will be added to driver core once its >> creation. All things left in pci_bus_add_devices() are >> driver att

Re: [PATCH 01/28] PCI: Rip out pci_bus_add_devices() from pci_scan_bus()

2015-01-16 Thread Yinghai Lu
On Thu, Jan 15, 2015 at 5:43 PM, Yijing Wang wrote: > Pci_bus_add_devices() should not be placed in pci_scan_bus(). > Now pci device will be added to driver core once its > creation. All things left in pci_bus_add_devices() are > driver attachment and other trivial sysfs things. > Pci_scan_bus() s

[PATCH 01/28] PCI: Rip out pci_bus_add_devices() from pci_scan_bus()

2015-01-15 Thread Yijing Wang
Pci_bus_add_devices() should not be placed in pci_scan_bus(). Now pci device will be added to driver core once its creation. All things left in pci_bus_add_devices() are driver attachment and other trivial sysfs things. Pci_scan_bus() should be the function responsible for scanning PCI devices, not